You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/17 03:14:32 UTC
[GitHub] [tvm] schell opened a new pull request #9765: fix: Rust - use build and source dirs when building tvm-sys
schell opened a new pull request #9765:
URL: https://github.com/apache/tvm/pull/9765
When building `tvm-sys`, the `TVMInstall::build_path` is set to `{build_dir}/{revision_branch}/build` and the `TVMInstall::source_path` is set to `{build_dir}/{revision_branch}/source`. But when using the `TVM_HOME` env var it uses the contents of the var as the path for both. This means there's no way to use `tvm-build` to manually build TVM and then use `TVM_HOME` to have `tvm-sys` compile bindings. It won't know where to find headers.
This fix just appends `build` and `source` to each `build_path` and `source_path` respectively in the case `TVM_HOME` is used so that it mimics the default behavior.
@jroesch @imalsogreg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #9765: fix: Rust - use build and source dirs when building tvm-sys
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #9765:
URL: https://github.com/apache/tvm/pull/9765#issuecomment-1016954195
I think this makes sense , sorry for slow response I was on vacation, and then got sick over the holidays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] schell commented on pull request #9765: fix: Rust - use build and source dirs when building tvm-sys
Posted by GitBox <gi...@apache.org>.
schell commented on pull request #9765:
URL: https://github.com/apache/tvm/pull/9765#issuecomment-1017973515
No worries @jroesch :). I hope your vacation was good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] schell commented on pull request #9765: fix: Rust - use build and source dirs when building tvm-sys
Posted by GitBox <gi...@apache.org>.
schell commented on pull request #9765:
URL: https://github.com/apache/tvm/pull/9765#issuecomment-1006883541
Any movement here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org