You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Bierce <da...@appcore.com> on 2014/05/01 00:24:11 UTC
Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management install
package creates log directory that is never used
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-6552
https://issues.apache.org/jira/browse/CLOUDSTACK-6552
Repository: cloudstack-git
Description
-------
The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
Diffs
-----
packaging/centos63/cloud.spec 83c598b
Diff: https://reviews.apache.org/r/20921/diff/
Testing
-------
Build RPMs on CentOS 6.4 and 6.5 using master
mvn clean install -Dnonoss -Dnoredist
package.sh -p noredist
Resulting packages installed on Centos 6.5 without the unused directory.
Thanks,
David Bierce
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552
Cloudstack-Management install package creates log directory that is never
used
Posted by Nux! <nu...@li.nux.ro>.
On 06.05.2014 10:14, Daan Hoogland wrote:
> hm, I'm not sure if you want to go that way then. You'll need to run
> validation builds and do magic with git. I'll apply it. In the mean
> while first get very proficient with git and maven.
Thanks!
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by Daan Hoogland <da...@gmail.com>.
hm, I'm not sure if you want to go that way then. You'll need to run
validation builds and do magic with git. I'll apply it. In the mean
while first get very proficient with git and maven.
On Tue, May 6, 2014 at 11:12 AM, Nux! <nu...@li.nux.ro> wrote:
> On 06.05.2014 09:45, Daan Hoogland wrote:
>>
>> Lucian,
>>
>> Did you apply it? Or just approved?
>
>
> Approved, I'm yet to learn how to actually apply it. :)
> BTW any docs that can put me in the right direction? I'm afraid I'm not
> versed in dev stuff.
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
--
Daan
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552
Cloudstack-Management install package creates log directory that is never
used
Posted by Nux! <nu...@li.nux.ro>.
On 06.05.2014 09:45, Daan Hoogland wrote:
> Lucian,
>
> Did you apply it? Or just approved?
Approved, I'm yet to learn how to actually apply it. :)
BTW any docs that can put me in the right direction? I'm afraid I'm not
versed in dev stuff.
Lucian
--
Sent from the Delta quadrant using Borg technology!
Nux!
www.nux.ro
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by Daan Hoogland <da...@gmail.com>.
Lucian,
Did you apply it? Or just approved?
On Mon, May 5, 2014 at 8:19 PM, Nux Ro <nu...@li.nux.ro> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/#review42174
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Nux Ro
>
>
> On April 30, 2014, 10:24 p.m., David Bierce wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20921/
>> -----------------------------------------------------------
>>
>> (Updated April 30, 2014, 10:24 p.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Bugs: CLOUDSTACK-6552
>> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>>
>>
>> Diffs
>> -----
>>
>> packaging/centos63/cloud.spec 83c598b
>>
>> Diff: https://reviews.apache.org/r/20921/diff/
>>
>>
>> Testing
>> -------
>>
>> Build RPMs on CentOS 6.4 and 6.5 using master
>>
>> mvn clean install -Dnonoss -Dnoredist
>> package.sh -p noredist
>>
>> Resulting packages installed on Centos 6.5 without the unused directory.
>>
>>
>> Thanks,
>>
>> David Bierce
>>
>>
>
--
Daan
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by Nux Ro <nu...@li.nux.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42174
-----------------------------------------------------------
Ship it!
Ship It!
- Nux Ro
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42263
-----------------------------------------------------------
Commit 5e067137617f28293b169d246c355cc268334c81 in cloudstack's branch refs/heads/4.4-forward from David Bierce
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5e06713 ]
CLOUDSTACK-6552 Cloudstack-Management install package creates log
directory that is never used
- ASF Subversion and Git Services
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by daan Hoogland <da...@gmail.com>.
> On May 6, 2014, 9:17 a.m., daan Hoogland wrote:
> > Can you commit to a branch locally and then in that branch generate with
> > $ git format-patch HEAD^1
> >
> > thanks
never mind. I had a closer look and just applied
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42262
-----------------------------------------------------------
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42262
-----------------------------------------------------------
Can you commit to a branch locally and then in that branch generate with
$ git format-patch HEAD^1
thanks
- daan Hoogland
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42264
-----------------------------------------------------------
Commit efccef485cb3e3f0a7d9e290653909750617f921 in cloudstack's branch refs/heads/4.4 from David Bierce
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=efccef4 ]
CLOUDSTACK-6552 Cloudstack-Management install package creates log
directory that is never used
- ASF Subversion and Git Services
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42265
-----------------------------------------------------------
Commit 59eed9ef77a041a6f30fc7522700a3d4c18b5637 in cloudstack's branch refs/heads/master from David Bierce
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59eed9e ]
CLOUDSTACK-6552 Cloudstack-Management install package creates log
directory that is never used
- ASF Subversion and Git Services
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>
Re: Review Request 20921: [PATCH] CLOUDSTACK-6552 Cloudstack-Management
install package creates log directory that is never used
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20921/#review42266
-----------------------------------------------------------
Ship it!
efccef485cb3e3f0a7d9e290653909750617f921 on 4.4
5e067137617f28293b169d246c355cc268334c81 on 4.4-forward
59eed9ef77a041a6f30fc7522700a3d4c18b5637 on master
- daan Hoogland
On April 30, 2014, 10:24 p.m., David Bierce wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20921/
> -----------------------------------------------------------
>
> (Updated April 30, 2014, 10:24 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-6552
> https://issues.apache.org/jira/browse/CLOUDSTACK-6552
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The RPM build cloud.spec creates a directory that is never used by cloudstack management and is just left as an empty directory name cloudstack-management in /var/log.
>
>
> Diffs
> -----
>
> packaging/centos63/cloud.spec 83c598b
>
> Diff: https://reviews.apache.org/r/20921/diff/
>
>
> Testing
> -------
>
> Build RPMs on CentOS 6.4 and 6.5 using master
>
> mvn clean install -Dnonoss -Dnoredist
> package.sh -p noredist
>
> Resulting packages installed on Centos 6.5 without the unused directory.
>
>
> Thanks,
>
> David Bierce
>
>