[GitHub] [drill] paul-rogers commented on a change in pull request #2000: DRILL-7607: support dynamic credit based flow control

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #2000: DRILL-7607: support dynamic credit based flow control
URL: https://github.com/apache/drill/pull/2000#discussion_r386148620
 
 

 ##########
 File path: protocol/src/main/protobuf/BitData.proto
 ##########
 @@ -50,3 +52,7 @@ message RuntimeFilterBDef{
   optional int32 hj_op_id = 7; // the operator id of the HashJoin which generates this RuntimeFilter
   optional int64 rf_identifier = 8; // the runtime filter identifier
 }
+
+message AckWithCredit{
 
 Review comment:
   Thanks for the explanation. As it turns out, the only consumer of the C++ code is the ODBC client, which is why I asked when I saw the C++ files changed.
   
   While forcing an all-in-one cluster upgrade is not good, it should be OK. Although the Drill Web console suggests that one can do a -1/+1 version upgrade, I don't think such an upgrade is ever tested. Let's just make sure we document the all-at-once upgrade requirement in the release notes of the next release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services