You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/11/15 19:19:21 UTC

Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/
-----------------------------------------------------------

Review request for Ambari, Ishan Bhatt and Yusaku Sako.


Bugs: AMBARI-22445
    https://issues.apache.org/jira/browse/AMBARI-22445


Repository: ambari


Description
-------

The mysql connector license is not compatible with Ambari's license and Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the user appropriately to install and setup mysql-connector to be used by Hive.


Diffs
-----

  ambari-web/app/views/common/controls_view.js f03e5c0 
  ambari-web/test/views/common/controls_view_test.js c5c5338 


Diff: https://reviews.apache.org/r/63847/diff/1/


Testing
-------

Manually tested.
Ambari-web unit tests pass
  30518 passing (27s)
  157 pending


Thanks,

Vivek Ratnavel Subramanian


Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

Posted by Ishan Bhatt <ib...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/#review191101
-----------------------------------------------------------


Ship it!




Ship It!

- Ishan Bhatt


On Nov. 15, 2017, 7:19 p.m., Vivek Ratnavel Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63847/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 7:19 p.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22445
>     https://issues.apache.org/jira/browse/AMBARI-22445
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The mysql connector license is not compatible with Ambari's license and Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the user appropriately to install and setup mysql-connector to be used by Hive.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/views/common/controls_view.js f03e5c0 
>   ambari-web/test/views/common/controls_view_test.js c5c5338 
> 
> 
> Diff: https://reviews.apache.org/r/63847/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested.
> Ambari-web unit tests pass
>   30518 passing (27s)
>   157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>


Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/
-----------------------------------------------------------

(Updated Nov. 30, 2017, 6:51 p.m.)


Review request for Ambari, Ishan Bhatt and Yusaku Sako.


Changes
-------

Update the warning message to be more helpful.


Bugs: AMBARI-22445
    https://issues.apache.org/jira/browse/AMBARI-22445


Repository: ambari


Description
-------

The mysql connector license is not compatible with Ambari's license and Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the user appropriately to install and setup mysql-connector to be used by Hive.


Diffs (updated)
-----

  ambari-web/app/messages.js 783baf1 
  ambari-web/app/views/common/controls_view.js 74c1e6e 
  ambari-web/test/views/common/controls_view_test.js 2d18396 


Diff: https://reviews.apache.org/r/63847/diff/2/

Changes: https://reviews.apache.org/r/63847/diff/1-2/


Testing
-------

Manually tested.
Ambari-web unit tests pass
  30518 passing (27s)
  157 pending


Thanks,

Vivek Ratnavel Subramanian