[GitHub] [hbase] infraio commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #974: HBASE-23587 The FSYNC_WAL flag does not work on branch-2.x
URL: https://github.com/apache/hbase/pull/974#discussion_r362356442
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
 ##########
 @@ -577,10 +577,9 @@ public void run() {
           //TraceScope scope = Trace.continueSpan(takeSyncFuture.getSpan());
           long start = System.nanoTime();
           Throwable lastException = null;
-          boolean wasRollRequested = false;
           try {
             TraceUtil.addTimelineAnnotation("syncing writer");
-            writer.sync(useHsync);
+            writer.sync(takeSyncFuture.isForceSync());
 
 Review comment:
   So the desion allow different table/mutation use different durability, but these table share one WAL writer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services