You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 14:04:58 UTC

[GitHub] [airflow] kazanzhy opened a new pull request #20138: Finalised Datastore documentation

kazanzhy opened a new pull request #20138:
URL: https://github.com/apache/airflow/pull/20138


   closes: #8204
   
   @mik-laj made a huge contribution to Datastore documentation last year.
   I just added two operators to the documentation.
   
   I think we can close issue #8204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kazanzhy commented on pull request #20138: Finalised Datastore documentation

Posted by GitBox <gi...@apache.org>.
kazanzhy commented on pull request #20138:
URL: https://github.com/apache/airflow/pull/20138#issuecomment-989859117


   Now seems to be ok @dstandish 
   The issue was in the file `tests/always/test_project_structure.py`. 
   I removed datastore classes from `MISSING_EXAMPLES_FOR_OPERATORS`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #20138: Finalised Datastore documentation

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20138:
URL: https://github.com/apache/airflow/pull/20138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dstandish commented on a change in pull request #20138: Finalised Datastore documentation

Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #20138:
URL: https://github.com/apache/airflow/pull/20138#discussion_r765171959



##########
File path: docs/apache-airflow-providers-google/operators/cloud/datastore.rst
##########
@@ -160,6 +160,33 @@ use :class:`~airflow.providers.google.cloud.operators.datastore.CloudDatastoreRo
     :start-after: [START how_to_rollback_transaction]
     :end-before: [END how_to_rollback_transaction]
 
+.. _howto/operator:CloudDatastoreGetOperationOperator:
+
+Get operation state
+-------------------
+
+To latest state of a long-running operation use
+:class:`~airflow.providers.google.cloud.operators.datastore.CloudDatastoreGetOperationOperator`
+
+.. exampleinclude:: /../../airflow/providers/google/cloud/example_dags/example_datastore.py
+    :language: python
+    :dedent: 4
+    :start-after: [START get_operation_state]
+    :end-before: [END get_operation_state]
+
+.. _howto/operator:CloudDatastoreDeleteOperationOperator:
+
+Delete operation
+----------------
+
+To delete the long-running operation use

Review comment:
       ```suggestion
   To delete an operation use
   ```
   does  it have to be "long-running"?

##########
File path: docs/apache-airflow-providers-google/operators/cloud/datastore.rst
##########
@@ -160,6 +160,33 @@ use :class:`~airflow.providers.google.cloud.operators.datastore.CloudDatastoreRo
     :start-after: [START how_to_rollback_transaction]
     :end-before: [END how_to_rollback_transaction]
 
+.. _howto/operator:CloudDatastoreGetOperationOperator:
+
+Get operation state
+-------------------
+
+To latest state of a long-running operation use

Review comment:
       ```suggestion
   To get the current state of a long-running operation use
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #20138: Finalised Datastore documentation

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20138:
URL: https://github.com/apache/airflow/pull/20138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org