You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by NielsLeenheer <gi...@git.apache.org> on 2016/11/10 14:30:24 UTC
[GitHub] cordova-ios pull request #276: The platform project directory needs to be re...
GitHub user NielsLeenheer opened a pull request:
https://github.com/apache/cordova-ios/pull/276
The platform project directory needs to be relative to the project
Launch screen images were not updated or cleaned in
`updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()`
because the check for `Images.xcassets` in
`getLaunchStoryboardImagesDir()` failed.
The reason was that the `platformProjDir` and `projectRoot` were
joined, while both were relative to the root directory. So the
resulting directory was non-sensical. This changes makes
`platformProjDir` relative to `cordovaProject.root`, which matches the
same check in `updateSplashScreens()` and `updateIcons()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NielsLeenheer/cordova-ios fix-generating-storyboard-images
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #276
----
commit 2a2e0f7dfb1ef315883ff70dbbb5b6a8f6213596
Author: Niels Leenheer <ni...@leenheer.nl>
Date: 2016-11-10T14:27:43Z
The platform project directory needs to be relative to the project
Launch screen images were not updated or cleaned in
`updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()`
because the check for `Images.xcassets` in
`getLaunchStoryboardImagesDir()` failed.
The reason was that the `platformProjDir` and `projectRoot` were
joined, while both were relative to the root directory. So the
resulting directory was non-sensical. This changes makes
`platformProjDir` relative to `cordovaProject.root`, which matches the
same check in `updateSplashScreens()` and `updateIcons()`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/276
Pulled in; thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/276
Awesome; thanks! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/276
@NielsLeenheer -- would you mind squashing these commits down to a single commit? I'd like to pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/276
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/276?src=pr) is 60.00% (diff: 50.00%)
> Merging [#276](https://codecov.io/gh/apache/cordova-ios/pull/276?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #276 diff @@
==========================================
Files 12 12
Lines 1325 1325
Methods 202 202
Messages 0 0
Branches 224 224
==========================================
Hits 795 795
Misses 530 530
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [50a185a...1a1dee4](https://codecov.io/gh/apache/cordova-ios/compare/50a185a6ec9e1b231cf0cddaddb6f74101c93f38...1a1dee4613f66ebf69164dc6ce2063d7a20947eb?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #276: CB-12130 - Launch storyboard images are not updated ...
Posted by NielsLeenheer <gi...@git.apache.org>.
Github user NielsLeenheer commented on the issue:
https://github.com/apache/cordova-ios/pull/276
Squashed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #276: CB-12130 - Launch storyboard images are not u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org