You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Andrei Dulceanu (JIRA)" <ji...@apache.org> on 2016/09/14 09:26:20 UTC
[jira] [Updated] (OAK-4801) Add test for DNS resolution failure in
ClientIpFilter
[ https://issues.apache.org/jira/browse/OAK-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Dulceanu updated OAK-4801:
---------------------------------
Attachment: OAK-4801-01.patch
* Created {{AddressResolver}} and {{InetAddressResolver}} for better testing {{ClientIPFilter}} without an actual DNS lookup
* Solved hostname with dashes limitation in {{ClientIpFilter}}
* Added {{ClientIPFilterHostnameTest}} for testing filters with hostnames (including dashes)
[~frm], can you take a look at the patch, please?
/cc [~marett]
> Add test for DNS resolution failure in ClientIpFilter
> -----------------------------------------------------
>
> Key: OAK-4801
> URL: https://issues.apache.org/jira/browse/OAK-4801
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Fix For: Segment Tar 0.0.20
>
> Attachments: OAK-4801-01.patch
>
>
> Per [~frm]'s suggestion, we could refactor a bit ClientIpFilter and extract the calls to {{InetAddress.getByName()}} into their own interface, say {{InetAddressResolver}}. We could then write a test with bogus implementation of {{InetAddressResolver}} and assert the behaviour of the {{ClientIpFilter}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)