You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/04/04 07:59:04 UTC
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12932
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
[kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Under mode UPSERT_TO_EXIST_TABLE, destination table is not empty before
copying, it may has more rows than source table, so it may still has
more rows than source table after copying.
Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 31 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/12932/1
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12932 )
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
[kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Under mode UPSERT_TO_EXIST_TABLE, destination table is not empty before
copying, it may has more rows than source table, so it may still has
more rows than source table after copying.
Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Reviewed-on: http://gerrit.cloudera.org:8080/12932
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 30 insertions(+), 25 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 )
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@572
PS1, Line 572: // Rows scaned from source table can be found in destination table.
scanned
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@583
PS1, Line 583: has
Nit: "should have"
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@643
PS1, Line 643: ww.set_write_batch_size(1);
Why this change?
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Apr 2019 17:52:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 )
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@572
PS1, Line 572: // Rows scaned from source table can be found in destination table.
> scanned
Done
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@583
PS1, Line 583: has
> Nit: "should have"
Done
http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@643
PS1, Line 643: ww.set_write_batch_size(1);
> Why this change?
Not related, I'll remove it.
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 13:45:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12932 )
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 16:02:05 +0000
Gerrit-HasComments: No
[kudu-CR] [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12932
to look at the new patch set (#2).
Change subject: [kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
......................................................................
[kudu-tool-test] deflake ToolTestCopyTableParameterized.TestCopyTable
Under mode UPSERT_TO_EXIST_TABLE, destination table is not empty before
copying, it may has more rows than source table, so it may still has
more rows than source table after copying.
Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 30 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/12932/2
--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)