[GitHub] [spark] kazuyukitanimura commented on a change in pull request #33898: [SPARK-36644][SQL] Push down boolean column filter

[GitBox <gi...@apache.org>]

kazuyukitanimura commented on a change in pull request #33898:
URL: https://github.com/apache/spark/pull/33898#discussion_r701366317



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -311,6 +312,21 @@ class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
     assert(PushableColumnAndNestedColumn.unapply(Abs('col.int)) === None)
   }
 
+  test("SPARK-36644: Push down boolean column filter") {
+    testTranslateFilter('col.boolean, Some(sources.EqualTo("col", true)))
+
+    val t = "test_table"
+    withTable(t) {
+      import testImplicits._
+      Seq(Some(true), Some(false), None).toDF().write.saveAsTable(t)
+      val df = spark.table(t)
+      df.where("value").queryExecution.executedPlan.collectFirst {

Review comment:
       updated and passed all tests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org