You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/02/12 15:49:43 UTC

Review Request 18004: Provide ability to forward request headers for Pass Through API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18004/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-4628
    https://issues.apache.org/jira/browse/AMBARI-4628


Repository: ambari


Description
-------

We need to forward both headers and body in Pass Through API.
For example, Falcon API requires sending Remote-user header in every query.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 6b5681c 
  ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java 9f7f108 
  ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 80c5c7d 

Diff: https://reviews.apache.org/r/18004/diff/


Testing
-------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Listening for transport dt_socket at address: 5006
Running org.apache.ambari.server.proxy.ProxyServiceTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.34 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Vitalyi Brodetskyi


Re: Review Request 18004: Provide ability to forward request headers for Pass Through API

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18004/#review34284
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 12, 2014, 2:49 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18004/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 2:49 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4628
>     https://issues.apache.org/jira/browse/AMBARI-4628
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need to forward both headers and body in Pass Through API.
> For example, Falcon API requires sending Remote-user header in every query.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 6b5681c 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java 9f7f108 
>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 80c5c7d 
> 
> Diff: https://reviews.apache.org/r/18004/diff/
> 
> 
> Testing
> -------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Listening for transport dt_socket at address: 5006
> Running org.apache.ambari.server.proxy.ProxyServiceTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.34 sec
> 
> Results :
> 
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 18004: Provide ability to forward request headers for Pass Through API

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18004/#review34283
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 12, 2014, 9:49 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18004/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 9:49 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4628
>     https://issues.apache.org/jira/browse/AMBARI-4628
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We need to forward both headers and body in Pass Through API.
> For example, Falcon API requires sending Remote-user header in every query.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 6b5681c 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java 9f7f108 
>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 80c5c7d 
> 
> Diff: https://reviews.apache.org/r/18004/diff/
> 
> 
> Testing
> -------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Listening for transport dt_socket at address: 5006
> Running org.apache.ambari.server.proxy.ProxyServiceTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.34 sec
> 
> Results :
> 
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>