You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Thiago Veronezi <th...@veronezi.org> on 2013/10/09 16:07:07 UTC
The installer does not execute the same logic for regular
"tar.gz/zip" tomee and drop-in war
Guys,
Do you remember why we call
"org.apache.tomee.installer.Installer#installAll" in tomee drop-in war and
"org.apache.tomee.installer.Installer#installFull" to build the tar.gz/zip
version of the server?
It turns out, the "installFull" method moves all tomee jar files to the
catalina lib directory. The "installAll" only adds "openejb-javaagent.jar"
and "tomee-loader.jar" to it.
The "installFull" uses the "org.apache.tomee.catalina.ServerListener"
class, but the "installAll" uses "org.apache.tomee.loader.OpenEJBListener".
Shouldn't we be using the same logic in both versions? Can we drop one of
the methods? I would prefer the drop-in version because it changes as
little as possible the catalina lib directory.
[]s,
Thiago.
Re: The installer does not execute the same logic for regular
"tar.gz/zip" tomee and drop-in war
Posted by Thiago Veronezi <th...@veronezi.org>.
Thanks for the tip! I will check it out later today.
[]s,
Thiago.
On Wed, Oct 9, 2013 at 10:44 AM, Romain Manni-Bucau
<rm...@gmail.com>wrote:
> Do a diff between libs? you surely moved files, not always possible
> dependeing on environment. installer is used at runtime to upgrade a drop
> in war tomcat-tomeewar in tomee.
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
> *Blog: **http://rmannibucau.wordpress.com/*<
> http://rmannibucau.wordpress.com/>
> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> *Github: https://github.com/rmannibucau*
>
>
>
> 2013/10/9 Thiago Veronezi <th...@veronezi.org>
>
> > Hmmmm... I changed the "SetupCommand.groovy" a bit in order to use the
> > "installAll" instead of "installFull", and it seems the server runs
> great.
> >
> > This is the change...
> >
> >
> >
> ************************************************************************************************************************************************************
> > Index:
> >
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> > IDEA additional info:
> > Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> > <+>UTF-8
> > ===================================================================
> > ---
> >
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> > (revision
> > 1530564)
> > +++
> >
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> > (revision
> > )
> > @@ -124,20 +124,7 @@
> > System.setProperty("catalina.base", "${catalinaHome}")
> > Paths paths = new Paths(new
> File("${catalinaHome}/webapps/tomee"))
> > Installer installer = new Installer(paths, true)
> > - installer.installFull()
> > -
> > - // clean up duplicate jars since in TomEE it is useless
> > - // = gain of space ;)
> > - ant.delete(file: paths.getJAXBImpl())
> > - ant.delete(file: paths.getOpenEJBTomcatLoaderJar())
> > - ant.delete(file: paths.findTomEELibJar("jaxb-impl"))
> > - ant.delete(file:
> > paths.findTomEELibJar("openejb-javaagent-${openejbVersion}.jar")) // we
> > need the one without version
> > -
> > - ant.delete(file:
> > "${paths.catalinaLibDir}/tomee-static-jquery-${tomeeVersion}.jar")
> > - ant.delete(file:
> > "${paths.catalinaLibDir}/tomee-static-bootstrap-${tomeeVersion}.jar")
> > -
> > - ant.delete(file: paths.findOpenEJBWebJar("tomee-loader"))
> > - ant.delete(file: paths.findOpenEJBWebJar("swizzle-stream"))
> > + installer.installAll()
> >
> > log.info("Assigning execute privileges to scripts in Tomcat bin
> > directory")
> > ant.chmod(dir: "${workDir}/apache-tomcat-${tomcatVersion}/bin",
> > perm: "u+x", includes: "**/*.sh")
> >
> >
> ************************************************************************************************************************************************************
> >
> > What am I missing?
> >
> > []s,
> > Thiago.
> >
> >
> >
> >
> > On Wed, Oct 9, 2013 at 10:12 AM, Romain Manni-Bucau
> > <rm...@gmail.com>wrote:
> >
> > > Hi
> > >
> > > one is war oriented (= you drop in war then you add config to get tomee
> > > ready to work) and one is tomee oriented (move libs etc).
> > >
> > > Both are needed since depending the case you don't start the same way.
> > >
> > > *Romain Manni-Bucau*
> > > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
> > > *Blog: **http://rmannibucau.wordpress.com/*<
> > > http://rmannibucau.wordpress.com/>
> > > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> > > *Github: https://github.com/rmannibucau*
> > >
> > >
> > >
> > > 2013/10/9 Thiago Veronezi <th...@veronezi.org>
> > >
> > > > Guys,
> > > >
> > > > Do you remember why we call
> > > > "org.apache.tomee.installer.Installer#installAll" in tomee drop-in
> war
> > > and
> > > > "org.apache.tomee.installer.Installer#installFull" to build the
> > > tar.gz/zip
> > > > version of the server?
> > > >
> > > > It turns out, the "installFull" method moves all tomee jar files to
> the
> > > > catalina lib directory. The "installAll" only adds
> > > "openejb-javaagent.jar"
> > > > and "tomee-loader.jar" to it.
> > > >
> > > > The "installFull" uses the "org.apache.tomee.catalina.ServerListener"
> > > > class, but the "installAll" uses
> > > "org.apache.tomee.loader.OpenEJBListener".
> > > >
> > > > Shouldn't we be using the same logic in both versions? Can we drop
> one
> > of
> > > > the methods? I would prefer the drop-in version because it changes as
> > > > little as possible the catalina lib directory.
> > > >
> > > > []s,
> > > > Thiago.
> > > >
> > >
> >
>
Re: The installer does not execute the same logic for regular
"tar.gz/zip" tomee and drop-in war
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Do a diff between libs? you surely moved files, not always possible
dependeing on environment. installer is used at runtime to upgrade a drop
in war tomcat-tomeewar in tomee.
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/10/9 Thiago Veronezi <th...@veronezi.org>
> Hmmmm... I changed the "SetupCommand.groovy" a bit in order to use the
> "installAll" instead of "installFull", and it seems the server runs great.
>
> This is the change...
>
>
> ************************************************************************************************************************************************************
> Index:
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> ---
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> (revision
> 1530564)
> +++
> ../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
> (revision
> )
> @@ -124,20 +124,7 @@
> System.setProperty("catalina.base", "${catalinaHome}")
> Paths paths = new Paths(new File("${catalinaHome}/webapps/tomee"))
> Installer installer = new Installer(paths, true)
> - installer.installFull()
> -
> - // clean up duplicate jars since in TomEE it is useless
> - // = gain of space ;)
> - ant.delete(file: paths.getJAXBImpl())
> - ant.delete(file: paths.getOpenEJBTomcatLoaderJar())
> - ant.delete(file: paths.findTomEELibJar("jaxb-impl"))
> - ant.delete(file:
> paths.findTomEELibJar("openejb-javaagent-${openejbVersion}.jar")) // we
> need the one without version
> -
> - ant.delete(file:
> "${paths.catalinaLibDir}/tomee-static-jquery-${tomeeVersion}.jar")
> - ant.delete(file:
> "${paths.catalinaLibDir}/tomee-static-bootstrap-${tomeeVersion}.jar")
> -
> - ant.delete(file: paths.findOpenEJBWebJar("tomee-loader"))
> - ant.delete(file: paths.findOpenEJBWebJar("swizzle-stream"))
> + installer.installAll()
>
> log.info("Assigning execute privileges to scripts in Tomcat bin
> directory")
> ant.chmod(dir: "${workDir}/apache-tomcat-${tomcatVersion}/bin",
> perm: "u+x", includes: "**/*.sh")
>
> ************************************************************************************************************************************************************
>
> What am I missing?
>
> []s,
> Thiago.
>
>
>
>
> On Wed, Oct 9, 2013 at 10:12 AM, Romain Manni-Bucau
> <rm...@gmail.com>wrote:
>
> > Hi
> >
> > one is war oriented (= you drop in war then you add config to get tomee
> > ready to work) and one is tomee oriented (move libs etc).
> >
> > Both are needed since depending the case you don't start the same way.
> >
> > *Romain Manni-Bucau*
> > *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
> > *Blog: **http://rmannibucau.wordpress.com/*<
> > http://rmannibucau.wordpress.com/>
> > *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> > *Github: https://github.com/rmannibucau*
> >
> >
> >
> > 2013/10/9 Thiago Veronezi <th...@veronezi.org>
> >
> > > Guys,
> > >
> > > Do you remember why we call
> > > "org.apache.tomee.installer.Installer#installAll" in tomee drop-in war
> > and
> > > "org.apache.tomee.installer.Installer#installFull" to build the
> > tar.gz/zip
> > > version of the server?
> > >
> > > It turns out, the "installFull" method moves all tomee jar files to the
> > > catalina lib directory. The "installAll" only adds
> > "openejb-javaagent.jar"
> > > and "tomee-loader.jar" to it.
> > >
> > > The "installFull" uses the "org.apache.tomee.catalina.ServerListener"
> > > class, but the "installAll" uses
> > "org.apache.tomee.loader.OpenEJBListener".
> > >
> > > Shouldn't we be using the same logic in both versions? Can we drop one
> of
> > > the methods? I would prefer the drop-in version because it changes as
> > > little as possible the catalina lib directory.
> > >
> > > []s,
> > > Thiago.
> > >
> >
>
Re: The installer does not execute the same logic for regular
"tar.gz/zip" tomee and drop-in war
Posted by Thiago Veronezi <th...@veronezi.org>.
Hmmmm... I changed the "SetupCommand.groovy" a bit in order to use the
"installAll" instead of "installFull", and it seems the server runs great.
This is the change...
************************************************************************************************************************************************************
Index:
../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
---
../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
(revision
1530564)
+++
../../trunk/tomee/apache-tomee/src/main/groovy/commands/SetupCommand.groovy
(revision
)
@@ -124,20 +124,7 @@
System.setProperty("catalina.base", "${catalinaHome}")
Paths paths = new Paths(new File("${catalinaHome}/webapps/tomee"))
Installer installer = new Installer(paths, true)
- installer.installFull()
-
- // clean up duplicate jars since in TomEE it is useless
- // = gain of space ;)
- ant.delete(file: paths.getJAXBImpl())
- ant.delete(file: paths.getOpenEJBTomcatLoaderJar())
- ant.delete(file: paths.findTomEELibJar("jaxb-impl"))
- ant.delete(file:
paths.findTomEELibJar("openejb-javaagent-${openejbVersion}.jar")) // we
need the one without version
-
- ant.delete(file:
"${paths.catalinaLibDir}/tomee-static-jquery-${tomeeVersion}.jar")
- ant.delete(file:
"${paths.catalinaLibDir}/tomee-static-bootstrap-${tomeeVersion}.jar")
-
- ant.delete(file: paths.findOpenEJBWebJar("tomee-loader"))
- ant.delete(file: paths.findOpenEJBWebJar("swizzle-stream"))
+ installer.installAll()
log.info("Assigning execute privileges to scripts in Tomcat bin
directory")
ant.chmod(dir: "${workDir}/apache-tomcat-${tomcatVersion}/bin",
perm: "u+x", includes: "**/*.sh")
************************************************************************************************************************************************************
What am I missing?
[]s,
Thiago.
On Wed, Oct 9, 2013 at 10:12 AM, Romain Manni-Bucau
<rm...@gmail.com>wrote:
> Hi
>
> one is war oriented (= you drop in war then you add config to get tomee
> ready to work) and one is tomee oriented (move libs etc).
>
> Both are needed since depending the case you don't start the same way.
>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
> *Blog: **http://rmannibucau.wordpress.com/*<
> http://rmannibucau.wordpress.com/>
> *LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
> *Github: https://github.com/rmannibucau*
>
>
>
> 2013/10/9 Thiago Veronezi <th...@veronezi.org>
>
> > Guys,
> >
> > Do you remember why we call
> > "org.apache.tomee.installer.Installer#installAll" in tomee drop-in war
> and
> > "org.apache.tomee.installer.Installer#installFull" to build the
> tar.gz/zip
> > version of the server?
> >
> > It turns out, the "installFull" method moves all tomee jar files to the
> > catalina lib directory. The "installAll" only adds
> "openejb-javaagent.jar"
> > and "tomee-loader.jar" to it.
> >
> > The "installFull" uses the "org.apache.tomee.catalina.ServerListener"
> > class, but the "installAll" uses
> "org.apache.tomee.loader.OpenEJBListener".
> >
> > Shouldn't we be using the same logic in both versions? Can we drop one of
> > the methods? I would prefer the drop-in version because it changes as
> > little as possible the catalina lib directory.
> >
> > []s,
> > Thiago.
> >
>
Re: The installer does not execute the same logic for regular
"tar.gz/zip" tomee and drop-in war
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi
one is war oriented (= you drop in war then you add config to get tomee
ready to work) and one is tomee oriented (move libs etc).
Both are needed since depending the case you don't start the same way.
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/10/9 Thiago Veronezi <th...@veronezi.org>
> Guys,
>
> Do you remember why we call
> "org.apache.tomee.installer.Installer#installAll" in tomee drop-in war and
> "org.apache.tomee.installer.Installer#installFull" to build the tar.gz/zip
> version of the server?
>
> It turns out, the "installFull" method moves all tomee jar files to the
> catalina lib directory. The "installAll" only adds "openejb-javaagent.jar"
> and "tomee-loader.jar" to it.
>
> The "installFull" uses the "org.apache.tomee.catalina.ServerListener"
> class, but the "installAll" uses "org.apache.tomee.loader.OpenEJBListener".
>
> Shouldn't we be using the same logic in both versions? Can we drop one of
> the methods? I would prefer the drop-in version because it changes as
> little as possible the catalina lib directory.
>
> []s,
> Thiago.
>