You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/06 07:12:31 UTC
[GitHub] [rocketmq] WonderMing13 opened a new issue, #5836: [code discussition] Should the method queryAssignment request again?
WonderMing13 opened a new issue, #5836:
URL: https://github.com/apache/rocketmq/issues/5836
1. the method **tryQueryAssignment** and the method **getRebalanceResultFromBroker** both request to the broker to execute the queryAssignment method
Why not pass the result returned by the method tryQueryAssignment to the method getRebalanceResultFromBroker, which can reduce a network request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussition] Should the method queryAssignment request again? [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1885959519
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #5836: [code discussition] Should the method queryAssignment request again?
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1376571791
> 
>
> 1. the method **tryQueryAssignment** and the method **getRebalanceResultFromBroker** both request to the broker to execute the queryAssignment method
>
> Why not pass the result returned by the method tryQueryAssignment to the method getRebalanceResultFromBroker, which can reduce a network request
I think this is really an enhancement, could you submit a pull request to polish it ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #5836: [code discussition] Should the method queryAssignment request again?
Posted by GitBox <gi...@apache.org>.
ni-ze commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1375027404
If the result is the same, I think it's not need to request twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] WonderMing13 commented on issue #5836: [code discussition] Should the method queryAssignment request again?
Posted by GitBox <gi...@apache.org>.
WonderMing13 commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1376690723
> > 
> >
> > 1. the method **tryQueryAssignment** and the method **getRebalanceResultFromBroker** both request to the broker to execute the queryAssignment method
> >
> > Why not pass the result returned by the method tryQueryAssignment to the method getRebalanceResultFromBroker, which can reduce a network request
>
> I think this is really an enhancement, could you submit a pull request to polish it ？
ok , I will try to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussition] Should the method queryAssignment request again? [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5836: [code discussition] Should the method queryAssignment request again?
URL: https://github.com/apache/rocketmq/issues/5836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] WonderMing13 closed issue #5836: [code discussition] Should the method queryAssignment request again?
Posted by GitBox <gi...@apache.org>.
WonderMing13 closed issue #5836: [code discussition] Should the method queryAssignment request again?
URL: https://github.com/apache/rocketmq/issues/5836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [code discussition] Should the method queryAssignment request again? [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1890801353
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org