[jira] [Commented] (YETUS-466) yetus_verify_entry returns wrong result when test at start or end of NEEDED_TESTS String

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616305#comment-15616305 ] 

stack commented on YETUS-466:
-----------------------------

If I change the body of the yetus_verify_entry to be this:

{code}
[[ " ${!1} " =~ \ ${2}\  ]];
{code}

... it makes verify work properly for me.

To change behavior of =~, need to mess w/ context.

But I'm such a hack when it comes to shell scripting and this stuff here in yetus is so pretty, I'm wary putting up a patch. I can put up a patch w/ the above in it but my sense is that the authors of the yetus scripts know better how this should be solved.

> yetus_verify_entry returns wrong result when test at start or end of NEEDED_TESTS String
> ----------------------------------------------------------------------------------------
>
>                 Key: YETUS-466
>                 URL: https://issues.apache.org/jira/browse/YETUS-466
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: stack
>
> I noticed this when a test that is claimed needed:
> {code}
> [Fri Oct 28 11:46:58 PDT 2016 DEBUG]: Adding hbaseprotoc to NEEDED_TESTS
> {code}
> ... but then a a later call to verify_needed_test was claiming the test was not needed (digging, its whether test is in the NEEDED_TESTS list... which it is in my case... just the last one on the list).
> Illustration after defining yetus_verify_entry in my local shell:
> {code}
> kalashnikov:precommit stack$ x="asflicense  cc  unit  hbaseprotoc "
> kalashnikov:precommit stack$ yetus_verify_entry x asflicense
> kalashnikov:precommit stack$ echo $?
> 1
> kalashnikov:precommit stack$ x="xxx asflicense  cc  unit  hbaseprotoc "
> kalashnikov:precommit stack$ yetus_verify_entry x asflicense
> kalashnikov:precommit stack$ echo $?
> 0
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)