You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/05/07 13:25:53 UTC
[GitHub] [eventmesh] mxsm opened a new pull request, #3881: [ISSUE #3880]Optimize ClientSessionGroupMapping
mxsm opened a new pull request, #3881:
URL: https://github.com/apache/eventmesh/pull/3881
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3880
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
- Optimize ClientSessionGroupMapping
- change ConcurrentHashMap<InetSocketAddress, Session> to ConcurrentHashMap<String, Session>
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3880]Optimize ClientSessionGroupMapping (eventmesh)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3881:
URL: https://github.com/apache/eventmesh/pull/3881#issuecomment-2070567970
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3880]Optimize ClientSessionGroupMapping (eventmesh)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3881:
URL: https://github.com/apache/eventmesh/pull/3881#issuecomment-2070568423
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3881?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `1.96078%` with `50 lines` in your changes are missing coverage. Please review.
> Project coverage is 13.93%. Comparing base [(`e1e9aca`)](https://app.codecov.io/gh/apache/eventmesh/commit/e1e9acab09291b2eb10f1a88ee28dd0103bf26a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`214e6e1`)](https://app.codecov.io/gh/apache/eventmesh/pull/3881?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 502 commits behind head on master.
> :exclamation: Current head 214e6e1 differs from pull request most recent head 0364e2d. Consider uploading reports for the commit 0364e2d to get more accurate results
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3881?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ol/tcp/client/group/ClientSessionGroupMapping.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fcore%2Fprotocol%2Ftcp%2Fclient%2Fgroup%2FClientSessionGroupMapping.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRTZXNzaW9uR3JvdXBNYXBwaW5nLmphdmE=) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ntime/core/protocol/tcp/client/task/HelloTask.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fcore%2Fprotocol%2Ftcp%2Fclient%2Ftask%2FHelloTask.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL0hlbGxvVGFzay5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ime/admin/handler/RejectClientByIpPortHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FRejectClientByIpPortHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0Q2xpZW50QnlJcFBvcnRIYW5kbGVyLmphdmE=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ntmesh/runtime/admin/handler/TCPClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FTCPClientHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVENQQ2xpZW50SGFuZGxlci5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../runtime/admin/handler/RejectAllClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FRejectAllClientHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0QWxsQ2xpZW50SGFuZGxlci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../runtime/admin/request/DeleteTCPClientRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Frequest%2FDeleteTCPClientRequest.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlVENQQ2xpZW50UmVxdWVzdC5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/admin/handler/RedirectClientByIpPortHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FRedirectClientByIpPortHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeUlwUG9ydEhhbmRsZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...dmin/handler/RedirectClientBySubSystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FRedirectClientBySubSystemHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeVN1YlN5c3RlbUhhbmRsZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../admin/handler/RejectClientBySubSystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FRejectClientBySubSystemHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0Q2xpZW50QnlTdWJTeXN0ZW1IYW5kbGVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ntime/admin/handler/ShowClientBySystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&filepath=eventmesh-runtime%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fruntime%2Fadmin%2Fhandler%2FShowClientBySystemHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvU2hvd0NsaWVudEJ5U3lzdGVtSGFuZGxlci5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [2 more](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3881 +/- ##
=========================================
Coverage 13.93% 13.93%
Complexity 1291 1291
=========================================
Files 570 570
Lines 28847 28833 -14
Branches 2811 2809 -2
=========================================
Hits 4019 4019
+ Misses 24455 24441 -14
Partials 373 373
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3881?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3881: [ISSUE #3880]Optimize ClientSessionGroupMapping
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3881:
URL: https://github.com/apache/eventmesh/pull/3881#issuecomment-1539610895
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3881](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (214e6e1) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/e1e9acab09291b2eb10f1a88ee28dd0103bf26a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1e9aca) will **decrease** coverage by `0.02%`.
> The diff coverage is `1.96%`.
> :exclamation: Current head 214e6e1 differs from pull request most recent head 0364e2d. Consider uploading reports for the commit 0364e2d to get more accurate results
```diff
@@ Coverage Diff @@
## master #3881 +/- ##
============================================
- Coverage 13.93% 13.92% -0.02%
Complexity 1291 1291
============================================
Files 570 570
Lines 28847 28829 -18
Branches 2811 2808 -3
============================================
- Hits 4019 4013 -6
+ Misses 24455 24441 -14
- Partials 373 375 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/admin/handler/RedirectClientByIpPortHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeUlwUG9ydEhhbmRsZXIuamF2YQ==) | `31.37% <0.00%> (ø)` | |
| [...dmin/handler/RedirectClientBySubSystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVkaXJlY3RDbGllbnRCeVN1YlN5c3RlbUhhbmRsZXIuamF2YQ==) | `9.09% <0.00%> (ø)` | |
| [.../runtime/admin/handler/RejectAllClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0QWxsQ2xpZW50SGFuZGxlci5qYXZh) | `12.50% <0.00%> (ø)` | |
| [...ime/admin/handler/RejectClientByIpPortHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0Q2xpZW50QnlJcFBvcnRIYW5kbGVyLmphdmE=) | `9.30% <0.00%> (ø)` | |
| [.../admin/handler/RejectClientBySubSystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUmVqZWN0Q2xpZW50QnlTdWJTeXN0ZW1IYW5kbGVyLmphdmE=) | `8.33% <0.00%> (ø)` | |
| [...ntime/admin/handler/ShowClientBySystemHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvU2hvd0NsaWVudEJ5U3lzdGVtSGFuZGxlci5qYXZh) | `15.38% <0.00%> (ø)` | |
| [...tmesh/runtime/admin/handler/ShowClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvU2hvd0NsaWVudEhhbmRsZXIuamF2YQ==) | `14.81% <0.00%> (ø)` | |
| [...ntmesh/runtime/admin/handler/TCPClientHandler.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVENQQ2xpZW50SGFuZGxlci5qYXZh) | `4.34% <0.00%> (+0.09%)` | :arrow_up: |
| [.../runtime/admin/request/DeleteTCPClientRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlVENQQ2xpZW50UmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ol/tcp/client/group/ClientSessionGroupMapping.java](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRTZXNzaW9uR3JvdXBNYXBwaW5nLmphdmE=) | `0.81% <0.00%> (+0.03%)` | :arrow_up: |
| ... and [3 more](https://app.codecov.io/gh/apache/eventmesh/pull/3881?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3881/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3880]Optimize ClientSessionGroupMapping (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #3881:
URL: https://github.com/apache/eventmesh/pull/3881#discussion_r1575620686
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientSessionGroupMapping.java:
##########
@@ -56,13 +55,11 @@ public class ClientSessionGroupMapping {
private static final Logger SESSION_LOGGER = LoggerFactory.getLogger("sessionLogger");
- private final ConcurrentHashMap<InetSocketAddress, Session> sessionTable = new ConcurrentHashMap<>();
+ private final ConcurrentHashMap<String/*ip:port*/, Session> sessionTable = new ConcurrentHashMap<>(64);
Review Comment:
May I ask that what's the main benefit of changing `InetSocketAddress` to `String`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org