[GitHub] [camel] marcingrzejszczak commented on pull request #9389: Micrometer Observation component

["marcingrzejszczak (via GitHub)" <gi...@apache.org>]

marcingrzejszczak commented on PR #9389:
URL: https://github.com/apache/camel/pull/9389#issuecomment-1450583451

   I fixed the conflicts and did some additional changes
   
   - modified the tracer api to introduce a low cardinality tag (those would be used for metrics and traces)
   - modified the current micrometer observation behaviour to remove the custom handlers
   
   Below you have a screenshot of a trace view for a very simple route
   
   ```
   @Component
   class MyRoute extends RouteBuilder {
   
   	@Override
   	public void configure() throws Exception {
   		from("direct://foo")
   				.log("hello")
   				.to("http://httpbin.org/headers");
   	}
   
   }
   ```
   
   ![image](https://user-images.githubusercontent.com/3297437/222219050-3f90989b-c981-4f09-bc58-1889b14873fe.png)
   
   With the Micrometer Observation you also get the following metric.
   
   ```
   MeterId{name='camel.operation', tags=[tag(HTTP_METHOD=GET),tag(HTTP_STATUS=200),tag(component=camel-http),tag(error=none)]}
   ```
   
   I also changed the behaviour so that it is close to the OpenTelemetry one but not the same - I will document the differences plus I've left the code in the tests that can be used to have the same behaviour.
   
   So the question to you is - do you find such information valuable (traces and metrics) in its current form if you were to troubleshoot any issues within a Camel based system? I can try a more complex scenario and we can discuss what metrics / tags can be more useful in your opinion. We can also play around with the names if you think e.g. name of the component should be there in a span name.
   
   As for Jakarta - Micrometer is working fine with JDK17.
   
   cc @bclozel 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org