You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@druid.apache.org by Julian Hyde <jh...@apache.org> on 2018/07/25 00:55:43 UTC
GitBox review comments
I know there is an open request with INFRA to route git review comments to a list other than dev. But until then, we are still getting a lot of messages on the list each day. A lot of them come in groups, as a reviewer makes multiple comments on a particular PR.
I believe git has a feature called “review” where a reviewer can make multiple comments and they all appear in the same email. Is this feature supported in gitbox? If so, could reviewers consider using it, in order to reduce the email volume?
Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org
Re: GitBox review comments
Posted by Julian Hyde <jh...@apache.org>.
Ah, I see. Thanks for clarifying.
> On Jul 24, 2018, at 6:43 PM, Gian Merlino <gi...@apache.org> wrote:
>
> There is a github feature to make multiple comments as a single "review",
> although from what I can see, gitbox splits those up into multiple emails
> anyway, so it doesn't help. I have poked Infra again on our ticket:
> https://issues.apache.org/jira/browse/INFRA-16674
>
> On Tue, Jul 24, 2018 at 5:55 PM Julian Hyde <jh...@apache.org> wrote:
>
>> I know there is an open request with INFRA to route git review comments to
>> a list other than dev. But until then, we are still getting a lot of
>> messages on the list each day. A lot of them come in groups, as a reviewer
>> makes multiple comments on a particular PR.
>>
>> I believe git has a feature called “review” where a reviewer can make
>> multiple comments and they all appear in the same email. Is this feature
>> supported in gitbox? If so, could reviewers consider using it, in order to
>> reduce the email volume?
>>
>> Julian
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
>> For additional commands, e-mail: dev-help@druid.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org
Re: GitBox review comments
Posted by Gian Merlino <gi...@apache.org>.
There is a github feature to make multiple comments as a single "review",
although from what I can see, gitbox splits those up into multiple emails
anyway, so it doesn't help. I have poked Infra again on our ticket:
https://issues.apache.org/jira/browse/INFRA-16674
On Tue, Jul 24, 2018 at 5:55 PM Julian Hyde <jh...@apache.org> wrote:
> I know there is an open request with INFRA to route git review comments to
> a list other than dev. But until then, we are still getting a lot of
> messages on the list each day. A lot of them come in groups, as a reviewer
> makes multiple comments on a particular PR.
>
> I believe git has a feature called “review” where a reviewer can make
> multiple comments and they all appear in the same email. Is this feature
> supported in gitbox? If so, could reviewers consider using it, in order to
> reduce the email volume?
>
> Julian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
> For additional commands, e-mail: dev-help@druid.apache.org
>
>