[GitHub] [spark] yifeih opened a new pull request #24411: [SPARK-27514] Skip collapsing windows with empty window expressions

[GitBox <gi...@apache.org>]

yifeih opened a new pull request #24411: [SPARK-27514] Skip collapsing windows with empty window expressions
URL: https://github.com/apache/spark/pull/24411
 
 
   ## What changes were proposed in this pull request?
   
   A previous change moved the removal of empty window expressions to the RemoveNoopOperations rule, which comes after the CollapseWindow rule. Therefore, by the time we get to CollapseWindow, we aren't guaranteed that empty windows have been removed. 
   
   A lengthier description and repro steps here: https://issues.apache.org/jira/browse/SPARK-27514
   
   ## How was this patch tested?
   
   A unit test, plus I reran the breaking case mentioned in the Jira ticket. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org