You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (JIRA)" <ji...@apache.org> on 2015/10/22 19:53:27 UTC
[jira] [Updated] (CASSANDRA-10571)
ClusteringIndexNamesFilter::shouldInclude is not implemented,
SinglePartitionNamesCommand not discarding the sstables it could
[ https://issues.apache.org/jira/browse/CASSANDRA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-10571:
------------------------------------------
Description:
Now that we use {{SinglePartitionNamesCommand}} in more places - where we'd previously use what is now {{SinglePartitionSliceCommand}} - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.
{{SinglePartitionNamesCommand::queryMemtableAndDiskInternal}} should prune sstables based on {{ClusteringIndexNamesFilter::shouldInclude}} output, and the latter must be replaced with an actual implementation instead of a {{TODO}}.
This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use {{collectAllData}}, and that *was* pruning sstable with non-overlapping clusterings.
was:
Now that we use {{SinglePartitionNamesCommand}} in more places - where we'd previously use what is now {{SinglePartitionSliceCommand}} - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.
{{SinglePartitionNamesCommand::queryMemtableAndDiskInternal}} should prune sstables based on {{ClusteringIndexNamesFilter::shouldInclude}} output, and the latter must be replaced with an actual implementation instead of a {{TODO}}.
Not a regression, but not doing so affects counts write path negatively.
> ClusteringIndexNamesFilter::shouldInclude is not implemented, SinglePartitionNamesCommand not discarding the sstables it could
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-10571
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10571
> Project: Cassandra
> Issue Type: Bug
> Reporter: Aleksey Yeschenko
> Assignee: Sylvain Lebresne
> Fix For: 3.0.0
>
>
> Now that we use {{SinglePartitionNamesCommand}} in more places - where we'd previously use what is now {{SinglePartitionSliceCommand}} - not being able to skip sstables with non-overlapping clusterings is actually a performance regression.
> {{SinglePartitionNamesCommand::queryMemtableAndDiskInternal}} should prune sstables based on {{ClusteringIndexNamesFilter::shouldInclude}} output, and the latter must be replaced with an actual implementation instead of a {{TODO}}.
> This is also a potentially a big regression in performance for counter writes (say, with DTCS), since before 3.0, the read-before-write code would use {{collectAllData}}, and that *was* pruning sstable with non-overlapping clusterings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)