You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/01 13:53:45 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5920: server: allow normal users to create isolated network without source nat
weizhouapache opened a new pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920
### Description
This PR allows normal users to create isolated networks without source nat.
fixes #5897
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026898374
your code looks good @weizhouapache can you think of the testing we need to do for this?
The obvious is just creating a network as normal user with a network offering without source-nat. But other than that?
Or do we just let it go with the generic regression testing on the RC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1027658626
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache removed a comment on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache removed a comment on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026927798
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026928637
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026867749
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026867492
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026927666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1028833048
> (1) root admin, can create shared, L2 and isolated with/without source nat
> (2) domain admin, can create L2 and isolated with/without source nat
> (2) normal user, can create L2 and isolated with/without source nat
above tested and functional, the with sourcenet offerings used were with full services enabled so
> Other features like firewall, lb, pf, static nat and vpc should work.
should all work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1027658299
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026905292
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1028132347
<b>Trillian test result (tid-3114)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31602 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5920-t3114-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5920: server: allow normal users to create isolated network without source nat
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026928637
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org