You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2020/04/14 09:43:24 UTC

[myfaces-tobago] branch master updated: add a title for date picker button

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/master by this push:
     new 3154ed0  add a title for date picker button
3154ed0 is described below

commit 3154ed0fdb1ea5a247fbe06c9d672e8efd5def94
Author: Henning Nöth <hn...@apache.org>
AuthorDate: Tue Apr 14 11:33:06 2020 +0200

    add a title for date picker button
    
    Issue: TOBAGO-2028
---
 .../myfaces/tobago/internal/renderkit/renderer/DateRenderer.java       | 3 +++
 .../org/apache/myfaces/tobago/context/TobagoResourceBundle.properties  | 1 +
 .../apache/myfaces/tobago/context/TobagoResourceBundle_de.properties   | 1 +
 .../apache/myfaces/tobago/context/TobagoResourceBundle_es.properties   | 1 +
 4 files changed, 6 insertions(+)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
index 777923e..72a7a09 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/DateRenderer.java
@@ -34,6 +34,7 @@ import org.apache.myfaces.tobago.renderkit.html.DataAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlAttributes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlButtonTypes;
 import org.apache.myfaces.tobago.renderkit.html.HtmlElements;
+import org.apache.myfaces.tobago.util.ResourceUtils;
 import org.apache.myfaces.tobago.webapp.TobagoResponseWriter;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -103,6 +104,8 @@ public class DateRenderer extends InRenderer {
         BootstrapClass.BTN_SECONDARY,
         BootstrapDateTimePickerClass.DATEPICKERBUTTON);
     writer.writeAttribute(HtmlAttributes.TYPE, HtmlButtonTypes.BUTTON);
+    writer.writeAttribute(HtmlAttributes.TITLE,
+        ResourceUtils.getString(facesContext, "date.title"), true);
     writer.writeAttribute(HtmlAttributes.DISABLED, date.isDisabled() || date.isReadonly());
     writer.writeAttribute(HtmlAttributes.TABINDEX, date.getTabIndex());
 
diff --git a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle.properties b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle.properties
index 9559e30..4329d89 100644
--- a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle.properties
+++ b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle.properties
@@ -37,6 +37,7 @@ sheet.sorting=Click to sort this column
 sheet.toPage=Page {0}
 file.selected={} files selected
 help.title=Help
+date.title=Date Picker
 date.today=Today
 date.cancel=Cancel
 date.clear=Clear
diff --git a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_de.properties b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_de.properties
index 64a0486..7a755c9 100644
--- a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_de.properties
+++ b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_de.properties
@@ -37,6 +37,7 @@ sheet.sorting=nach dieser Spalte sortieren
 sheet.toPage=Seite {0}
 file.selected={} Dateien ausgew\u00E4hlt
 help.title=Hilfe
+date.title=Datumsauswahl
 date.today=Heute
 date.cancel=Abbrechen
 date.clear=L\u00F6schen
diff --git a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_es.properties b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_es.properties
index c755b82..04d5453 100644
--- a/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_es.properties
+++ b/tobago-core/src/main/resources/org/apache/myfaces/tobago/context/TobagoResourceBundle_es.properties
@@ -37,6 +37,7 @@ sheet.sorting=Ordenar por esta columna
 sheet.toPage=P\u00E1gina {0}
 file.selected={} archivos seleccionados
 help.title=Ayudar
+date.title=Escoger fecha
 date.today=Hoy
 date.cancel=Cancelar
 date.clear=Borrar