You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2018/09/27 20:51:38 UTC

[GitHub] [geode] kirklund opened pull request #2525: GEODE-2644: Use LINE_SEPARATOR in logging classes

Use org.apache.commons.lang.SystemUtils.LINE_SEPARATOR instead of \n.

These are all of the hardcoded \n I could find in a the internal.logging package (and sub-packages) except for the chars in LogWriterImpl#formatText.

I left LogWriterImpl#formatText alone. This method is iterating over chars and decrementing a count for every \n and \r found. Since this is dealing with char instead of String and it actually works on Windows as written, I left it alone for now. We can eventually rewrite this method with some new unit tests but that's a little more work than just replacing \n with LINE_SEPARATOR.

[ Full content available at: https://github.com/apache/geode/pull/2525 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2525: GEODE-2644: Use LINE_SEPARATOR in logging classes

Posted by "kirklund (GitHub)" <gi...@apache.org>.

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2525 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org