You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2026/01/27 04:01:26 UTC
[PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
sollhui opened a new pull request, #60255:
URL: https://github.com/apache/doris/pull/60255
### What problem does this PR solve?
Include AllMemTableMemory in load memory tracking to make load memory statistics more accurate, which are beneficial for controlling load memory.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3802964392
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3803667256
# BE UT Coverage Report
Increment line coverage `66.67% (2/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/370f105104ff5c092d99ac74e0efd598cf842ece_370f105104ff5c092d99ac74e0efd598cf842ece/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/370f105104ff5c092d99ac74e0efd598cf842ece_370f105104ff5c092d99ac74e0efd598cf842ece/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.53% (19173/36501) |
| Line Coverage | 35.92% (178364/496535) |
| Region Coverage | 32.36% (137848/425944) |
| Branch Coverage | 33.32% (59703/179195) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3803039834
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3803304552
<details>
<summary>ClickBench: <b>Total hot run time: 28.32 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 370f105104ff5c092d99ac74e0efd598cf842ece, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.04 0.04
query3 0.25 0.08 0.08
query4 1.60 0.11 0.12
query5 0.27 0.24 0.27
query6 1.16 0.67 0.68
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.56 0.49 0.49
query10 0.56 0.55 0.54
query11 0.14 0.09 0.10
query12 0.14 0.11 0.12
query13 0.63 0.61 0.62
query14 1.06 1.05 1.07
query15 0.88 0.86 0.87
query16 0.42 0.39 0.39
query17 1.15 1.17 1.12
query18 0.22 0.21 0.21
query19 2.10 1.92 2.05
query20 0.02 0.02 0.01
query21 15.42 0.24 0.15
query22 5.38 0.05 0.04
query23 16.04 0.29 0.10
query24 2.29 0.57 0.30
query25 0.09 0.08 0.06
query26 0.14 0.14 0.14
query27 0.09 0.05 0.05
query28 4.12 1.14 0.96
query29 12.59 3.91 3.21
query30 0.27 0.14 0.11
query31 2.81 0.62 0.41
query32 3.23 0.58 0.49
query33 3.23 3.21 3.24
query34 16.38 5.43 4.73
query35 4.76 4.84 4.83
query36 0.65 0.50 0.49
query37 0.11 0.07 0.07
query38 0.08 0.04 0.04
query39 0.04 0.03 0.02
query40 0.18 0.17 0.16
query41 0.08 0.03 0.03
query42 0.04 0.03 0.03
query43 0.05 0.04 0.03
Total cold run time: 99.46 s
Total hot run time: 28.32 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3802964604
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60255:
URL: https://github.com/apache/doris/pull/60255#issuecomment-3803262679
<details>
<summary>TPC-H: <b>Total hot run time: 33348 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 370f105104ff5c092d99ac74e0efd598cf842ece, data reload: false
------ Round 1 ----------------------------------
q1 17652 5301 5078 5078
q2 2021 345 193 193
q3 10190 1359 775 775
q4 10208 866 313 313
q5 7519 2152 1953 1953
q6 200 178 147 147
q7 888 740 598 598
q8 9267 1352 1142 1142
q9 5385 4922 4873 4873
q10 6881 1955 1585 1585
q11 525 308 268 268
q12 380 380 223 223
q13 17788 4129 3271 3271
q14 235 249 218 218
q15 910 827 826 826
q16 687 702 625 625
q17 635 796 493 493
q18 7282 6729 7363 6729
q19 1107 1025 641 641
q20 420 387 232 232
q21 3097 2224 2080 2080
q22 1130 1085 1109 1085
Total cold run time: 104407 ms
Total hot run time: 33348 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5532 5443 5599 5443
q2 265 342 267 267
q3 2428 2823 2703 2703
q4 1473 1849 1448 1448
q5 4731 4509 4664 4509
q6 232 182 150 150
q7 2022 1975 1936 1936
q8 2611 2376 2374 2374
q9 7545 7604 7666 7604
q10 2853 3058 2573 2573
q11 539 460 451 451
q12 715 799 639 639
q13 3855 4044 3266 3266
q14 281 285 271 271
q15 833 786 809 786
q16 677 678 634 634
q17 1082 1271 1303 1271
q18 7585 7468 7222 7222
q19 842 816 785 785
q20 1983 2089 1889 1889
q21 4750 4178 4148 4148
q22 1081 1023 977 977
Total cold run time: 53915 ms
Total hot run time: 51346 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](memory) include AllMemTableMemory in load memory tracking [doris]
Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui closed pull request #60255: [fix](memory) include AllMemTableMemory in load memory tracking
URL: https://github.com/apache/doris/pull/60255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org