You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jim Kellerman (JIRA)" <ji...@apache.org> on 2008/09/26 21:17:44 UTC
[jira] Created: (HBASE-905) Remove V5 migration classes from 0.19.0
Remove V5 migration classes from 0.19.0
---------------------------------------
Key: HBASE-905
URL: https://issues.apache.org/jira/browse/HBASE-905
Project: Hadoop HBase
Issue Type: Task
Components: util
Reporter: Jim Kellerman
Assignee: Jim Kellerman
Fix For: 0.19.0
The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-905) Remove V5 migration classes from
0.19.0
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635048#action_12635048 ]
Jim Kellerman commented on HBASE-905:
-------------------------------------
Can we make package.html more generic and move it up to org.apache.hadoop.hbase.util.migrate?
I think we should leave TestMigrate, although maybe change its name so it isn't run as a test. What's left are some really useful utility methods that we might need in some future migration test.
+1 on adding links to messages.
I'll update the Wiki when this gets committed.
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
> Attachments: hbase-905-v1.patch
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-905) Remove V5 migration classes from 0.19.0
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-905:
-------------------------------------
Attachment: hbase-905-v1.patch
Does exactly what Jim described. Please review.
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
> Attachments: hbase-905-v1.patch
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-905) Remove V5 migration classes from
0.19.0
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman resolved HBASE-905.
---------------------------------
Resolution: Fixed
Committed Jean-Daniel's changes to Migrate.java and TestMigrate.java. Removed v5 directory. Moved package.html to org.apache.hadoop.hbase.util.migration and modified this documentation to describe the migration process in more general terms than a specific migration. Updated migration documentation on Wiki.
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
> Attachments: hbase-905-v1.patch
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-905) Remove V5 migration classes from
0.19.0
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634986#action_12634986 ]
Jim Kellerman commented on HBASE-905:
-------------------------------------
In order to make this change:
- delete the package org.apache.hadoop.hbase.util.migration.v5
- change org.apache.hadoop.hbase.util.TestMigrate so that the method testUpgrade has an empty body, but leave the private methods (they may be useful in the future).
- change org.apache.hadoop.hbase.util.Migrate so that it no longer references the v5 classes, and will not perform an upgrade unless the file system version is at least 4. Also remove the methods: migrateToV5, rewriteMetaHRegionInfo, updateHRegionInfo, addHistorianFamilyToMeta, and updateBloomFilters.
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-905) Remove V5 migration classes from
0.19.0
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635002#action_12635002 ]
stack commented on HBASE-905:
-----------------------------
On patch:
+ Sob. You are removing things like the nice package.html I made describing migration for v5.
+ In messages like this, + " does not exist. No upgrade possible");, perhaps point user to the migration page in wiki instead of just let them hanging?
+ Maybe add link here too? (I like the below message though):
+ String msg = "Cannot upgrade from " + versionStr + " to " +
+ HConstants.FILE_SYSTEM_VERSION + " you must install hbase-0.2.x, run " +
+ "the upgrade tool, reinstall this version and run this utility again";
+ TestMigrate does nothing now. Its been exorcised. Its guts removed. Should we leave it in place though it does 'nothing'? This test was great for figuring something that needed migrating that had been overlooked.
Otherwise, patch is great. Apply. Its all removes.
Who's going to update the migration page on wiki. Should be part of this issue I'd say.
Good stuff.
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
> Attachments: hbase-905-v1.patch
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-905) Remove V5 migration classes from
0.19.0
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634976#action_12634976 ]
Jean-Daniel Cryans commented on HBASE-905:
------------------------------------------
+1
> Remove V5 migration classes from 0.19.0
> ---------------------------------------
>
> Key: HBASE-905
> URL: https://issues.apache.org/jira/browse/HBASE-905
> Project: Hadoop HBase
> Issue Type: Task
> Components: util
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Fix For: 0.19.0
>
>
> The V5 migration package was needed to migrate from hbase-0.1.x to hbase-0.2.x (and also can migrate from 0.1 to 0.18.x)
> As migration is very complex, if a migration is needed to 0.19 or a future release, removing these classes and modifying the migration too to not require them will simplify future migrations.
> A note will be placed on the Wiki notifying users that if they need to migrate from 0.1 to 0.19 (or greater), they must first install 0.2.x or 0.18.x, run the migration, and then install the new version to migrate to it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.