[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16136: [refactor](remove expr) remove non vectorized Expr and ExprContext related codes

[github-actions]

github-actions[bot] commented on code in PR #16136:
URL: https://github.com/apache/doris/pull/16136#discussion_r1084169844


##########
be/src/exprs/cast_functions.h:
##########
@@ -24,6 +24,20 @@
 
 namespace doris {
 
+using doris_udf::FunctionContext;
+using doris_udf::BooleanVal;
+using doris_udf::TinyIntVal;
+using doris_udf::SmallIntVal;
+using doris_udf::IntVal;
+using doris_udf::BigIntVal;
+using doris_udf::LargeIntVal;
+using doris_udf::FloatVal;
+using doris_udf::DoubleVal;
+using doris_udf::DecimalV2Val;

Review Comment:
   warning: using decl 'DecimalV2Val' is unused [misc-unused-using-decls]
   ```cpp
   using doris_udf::DecimalV2Val;
                    ^
   ```
   **be/src/exprs/cast_functions.h:35:** remove the using
   ```cpp
   using doris_udf::DecimalV2Val;
                    ^
   ```
   



##########
be/test/exprs/runtime_filter_test.cpp:
##########
@@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/runtime_filter.h"
+
+#include <array>
+#include <memory>
+
+#include "exprs/bloom_filter_func.h"
+#include "gen_cpp/Planner_types.h"
+#include "gen_cpp/Types_types.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_filter_mgr.h"
+#include "runtime/runtime_state.h"
+
+namespace doris {
+TTypeDesc create_type_desc(PrimitiveType type, int precision, int scale);
+
+class RuntimeFilterTest : public testing::Test {
+public:
+    RuntimeFilterTest() {}

Review Comment:
   warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
   
   ```suggestion
       RuntimeFilterTest() = default;
   ```
   



##########
be/test/exprs/runtime_filter_test.cpp:
##########
@@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/runtime_filter.h"
+
+#include <array>
+#include <memory>
+
+#include "exprs/bloom_filter_func.h"
+#include "gen_cpp/Planner_types.h"
+#include "gen_cpp/Types_types.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_filter_mgr.h"
+#include "runtime/runtime_state.h"
+
+namespace doris {
+TTypeDesc create_type_desc(PrimitiveType type, int precision, int scale);

Review Comment:
   warning: redundant 'create_type_desc' declaration [readability-redundant-declaration]
   
   ```suggestion
   
   ```
   **be/src/runtime/types.h:237:** previously declared here
   ```cpp
   TTypeDesc create_type_desc(PrimitiveType type, int precision = 0, int scale = 0);
             ^
   ```
   



##########
be/test/exprs/runtime_filter_test.cpp:
##########
@@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/runtime_filter.h"
+
+#include <array>
+#include <memory>
+
+#include "exprs/bloom_filter_func.h"
+#include "gen_cpp/Planner_types.h"
+#include "gen_cpp/Types_types.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_filter_mgr.h"
+#include "runtime/runtime_state.h"
+
+namespace doris {
+TTypeDesc create_type_desc(PrimitiveType type, int precision, int scale);
+
+class RuntimeFilterTest : public testing::Test {
+public:
+    RuntimeFilterTest() {}
+    virtual void SetUp() {
+        ExecEnv* exec_env = ExecEnv::GetInstance();
+        exec_env = nullptr;
+        _runtime_stat.reset(
+                new RuntimeState(_fragment_id, _query_options, _query_globals, exec_env));
+        _runtime_stat->init_mem_trackers();
+    }
+    virtual void TearDown() { _obj_pool.clear(); }

Review Comment:
   warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
   
   ```suggestion
       void TearDown() override { _obj_pool.clear(); }
   ```
   



##########
be/src/exprs/cast_functions.h:
##########
@@ -24,6 +24,20 @@
 
 namespace doris {
 
+using doris_udf::FunctionContext;
+using doris_udf::BooleanVal;
+using doris_udf::TinyIntVal;
+using doris_udf::SmallIntVal;
+using doris_udf::IntVal;
+using doris_udf::BigIntVal;
+using doris_udf::LargeIntVal;
+using doris_udf::FloatVal;
+using doris_udf::DoubleVal;
+using doris_udf::DecimalV2Val;
+using doris_udf::DateTimeVal;
+using doris_udf::StringVal;
+using doris_udf::AnyVal;

Review Comment:
   warning: using decl 'AnyVal' is unused [misc-unused-using-decls]
   ```cpp
   using doris_udf::AnyVal;
                    ^
   ```
   **be/src/exprs/cast_functions.h:38:** remove the using
   ```cpp
   using doris_udf::AnyVal;
                    ^
   ```
   



##########
be/test/exprs/runtime_filter_test.cpp:
##########
@@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/runtime_filter.h"
+
+#include <array>
+#include <memory>
+
+#include "exprs/bloom_filter_func.h"
+#include "gen_cpp/Planner_types.h"
+#include "gen_cpp/Types_types.h"
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_filter_mgr.h"
+#include "runtime/runtime_state.h"
+
+namespace doris {
+TTypeDesc create_type_desc(PrimitiveType type, int precision, int scale);
+
+class RuntimeFilterTest : public testing::Test {
+public:
+    RuntimeFilterTest() {}
+    virtual void SetUp() {

Review Comment:
   warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
   
   ```suggestion
       void SetUp() override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org