You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/05/10 21:04:39 UTC
[GitHub] [beam] Abacn opened a new pull request, #26652: Remove fetching committer GitHub account name in seed job
Abacn opened a new pull request, #26652:
URL: https://github.com/apache/beam/pull/26652
Fixes #26602
Since May 8, Jenkins slave nodes can no longer access to the LDAP server and seed job permared since them. In addition to that, LDAP no longer hosts beam committers' GitHub usernames (https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24579?filter=allopenissues). This PR removes the changes made in #12407 and brings seed job back green.
For now, unless manually populate Committer.groovy, comment trigger will not work for the following jobs:
- seed_00_job
- seed_job_standalone
- beam_Publish_Docker_Snapshots
- beam_Dependency_Check
- beam_Metrics_Report
the latter 3 defined `enablePhraseTriggeringFromPullRequest(prPermitAll=false)`
Committers can still trigger these jobs against a PR via Jenkins UI. The steps is:
- In https://ci-beam.apache.org/ choose the task to run, in Configure tab, Add Parameter -> Add String parameter, add a parameter named `ghprbPullId` and Save
- In Build with Parameters tab, fill sha1 with `origin/pr/4001/head` and ghprbPullId as `4001` then build.
Note that this method build the seed job directly from the PR branch, not that the PR branch merged onto master (as the triggers originally did). So rebase onto the latest master before running the seed job is recommended
We may still want to find a new way to fetch committer github user names. However the recommendation in https://issues.apache.org/jira/projects/INFRA/issues/INFRA-24579?filter=allopenissues (INFRA provided a relay to pass the trigger to Jenkins GitHub hook only the author is committer) does not quite fit the current workflow
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26652:
URL: https://github.com/apache/beam/pull/26652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26652:
URL: https://github.com/apache/beam/pull/26652#issuecomment-1544189151
>
Thanks, sent https://lists.apache.org/thread/f9koxtfytldz1hr78zhdn5f8g8tzcc3q to the devlist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26652:
URL: https://github.com/apache/beam/pull/26652#discussion_r1191345827
##########
.test-infra/jenkins/job_00_seed.groovy:
##########
@@ -73,8 +73,8 @@ job('beam_SeedJob') {
}
triggers {
- // Run every six hours
- cron('H H/6 * * *')
+ // Run every six hours, alternate job_seed_standalonw has same freq
Review Comment:
```suggestion
// Run every six hours, alternate job_seed_standalone has same freq
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26652:
URL: https://github.com/apache/beam/pull/26652#discussion_r1191180061
##########
.test-infra/jenkins/job_00_seed.groovy:
##########
@@ -104,18 +104,6 @@ job('beam_SeedJob') {
}
steps {
- shell {
- command("""
- ( cd .test-infra/jenkins/committers_list_generator &&
- python3.8 -m venv ve3 && source ve3/bin/activate &&
- pip install --retries 10 --upgrade pip setuptools wheel &&
- pip install --retries 10 -r requirements.txt &&
- python main.py -o .. &&
- deactivate ) ||
- { echo "ERROR: Failed to fetch committers"; exit 3; }
- """)
- unstableReturn(3)
- }
Review Comment:
Instead of killing everything in committers_list_generator, can we just get rid of this section for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26652:
URL: https://github.com/apache/beam/pull/26652#discussion_r1191180061
##########
.test-infra/jenkins/job_00_seed.groovy:
##########
@@ -104,18 +104,6 @@ job('beam_SeedJob') {
}
steps {
- shell {
- command("""
- ( cd .test-infra/jenkins/committers_list_generator &&
- python3.8 -m venv ve3 && source ve3/bin/activate &&
- pip install --retries 10 --upgrade pip setuptools wheel &&
- pip install --retries 10 -r requirements.txt &&
- python main.py -o .. &&
- deactivate ) ||
- { echo "ERROR: Failed to fetch committers"; exit 3; }
- """)
- unstableReturn(3)
- }
Review Comment:
Instead of killing everything in committers_list_generator, can we just get rid of this section for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26652:
URL: https://github.com/apache/beam/pull/26652#issuecomment-1542814918
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26652: Remove fetching committer GitHub account name in seed job
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26652:
URL: https://github.com/apache/beam/pull/26652#issuecomment-1542813744
Triggered seed job: https://ci-beam.apache.org/job/beam_SeedJob/11557/console
R: @damccorm @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org