You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Carlos Santana <cs...@gmail.com> on 2013/06/23 17:29:48 UTC
Re: Review Request: [CB-3978] Problem with cordova-cli when Xcode's version
is reported with two digits like 4.5, 4.7 or 5.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12056/
-----------------------------------------------------------
(Updated June 23, 2013, 3:29 p.m.)
Review request for cordova, Fil Maj and Shazron Abdullah.
Description
-------
[CB-3978] Problem with cordova-cli when Xcode's version is reported with two digits like 4.5, 4.7 or 5.0
Diffs
-----
src/metadata/ios_parser.js 343a72b
Diff: https://reviews.apache.org/r/12056/diff/
Testing
-------
tested with strings
4.5
4.7
5.0
Thanks,
Carlos Santana
Re: Review Request 12056: [CB-3978] Problem with cordova-cli when Xcode's
version is reported with two digits like 4.5, 4.7 or 5.0
Posted by Andrew Grieve <ag...@chromium.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12056/#review23088
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Grieve
On June 23, 2013, 3:29 p.m., Carlos Santana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12056/
> -----------------------------------------------------------
>
> (Updated June 23, 2013, 3:29 p.m.)
>
>
> Review request for cordova, Fil Maj and Shazron Abdullah.
>
>
> Repository: cordova-cli
>
>
> Description
> -------
>
> [CB-3978] Problem with cordova-cli when Xcode's version is reported with two digits like 4.5, 4.7 or 5.0
>
>
> Diffs
> -----
>
> src/metadata/ios_parser.js 343a72b
>
> Diff: https://reviews.apache.org/r/12056/diff/
>
>
> Testing
> -------
>
> tested with strings
> 4.5
> 4.7
> 5.0
>
>
> Thanks,
>
> Carlos Santana
>
>