You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ri...@apache.org on 2022/12/07 17:43:09 UTC

[beam] branch master updated: fix go lints (#24566)

This is an automated email from the ASF dual-hosted git repository.

riteshghorse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 6c24637b451 fix go lints (#24566)
6c24637b451 is described below

commit 6c24637b451d762ba39f54a56a8a335283173307
Author: Ritesh Ghorse <ri...@gmail.com>
AuthorDate: Wed Dec 7 23:13:00 2022 +0530

    fix go lints (#24566)
---
 sdks/go/pkg/beam/core/graph/xlang.go   |  2 +-
 sdks/go/pkg/beam/core/typex/special.go | 12 +++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/sdks/go/pkg/beam/core/graph/xlang.go b/sdks/go/pkg/beam/core/graph/xlang.go
index 8d2d0b324ef..eeb86f6464d 100644
--- a/sdks/go/pkg/beam/core/graph/xlang.go
+++ b/sdks/go/pkg/beam/core/graph/xlang.go
@@ -52,7 +52,7 @@ func init() {
 // unnecesary proto related imports into graph.
 type ExpandedTransform struct {
 	Components   any // *pipepb.Components
-	Transform    any //*pipepb.PTransform
+	Transform    any // *pipepb.PTransform
 	Requirements []string
 }
 
diff --git a/sdks/go/pkg/beam/core/typex/special.go b/sdks/go/pkg/beam/core/typex/special.go
index 067cef1fb4f..93537122584 100644
--- a/sdks/go/pkg/beam/core/typex/special.go
+++ b/sdks/go/pkg/beam/core/typex/special.go
@@ -74,15 +74,21 @@ type BundleFinalization interface {
 	RegisterCallback(time.Duration, func() error)
 }
 
+// PaneTiming defines the pane timing in byte.
 type PaneTiming byte
 
 const (
-	PaneEarly   PaneTiming = 0
-	PaneOnTime  PaneTiming = 1
-	PaneLate    PaneTiming = 2
+	// PaneEarly defines early pane timing.
+	PaneEarly PaneTiming = 0
+	// PaneOnTime defines on-time pane timing.
+	PaneOnTime PaneTiming = 1
+	// PaneLate defines late pane timing.
+	PaneLate PaneTiming = 2
+	// PaneUnknown defines unknown pane timing.
 	PaneUnknown PaneTiming = 3
 )
 
+// PaneInfo represents the output pane.
 type PaneInfo struct {
 	Timing                     PaneTiming
 	IsFirst, IsLast            bool