You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/19 22:58:00 UTC

[jira] [Commented] (OPENNLP-1049) Rename snowball stemmer classes for Java naming conformance

    [ https://issues.apache.org/jira/browse/OPENNLP-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297558#comment-16297558 ] 

ASF GitHub Bot commented on OPENNLP-1049:
-----------------------------------------

jzonthemtn closed pull request #190: OPENNLP-1049: Renames stemmer classes per Java conventions.
URL: https://github.com/apache/opennlp/pull/190
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DanishStemmer.java
similarity index 98%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DanishStemmer.java
index 67ad85f3f..a2a9ce84d 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/danishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DanishStemmer.java
@@ -38,11 +38,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class danishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class DanishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static danishStemmer methodObject = new danishStemmer ();
+        private final static DanishStemmer methodObject = new DanishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "hed", -1, 1, "", methodObject ),
@@ -102,7 +102,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private java.lang.StringBuilder S_ch = new java.lang.StringBuilder();
 
-                private void copy_from(danishStemmer other) {
+                private void copy_from(DanishStemmer other) {
                     I_x = other.I_x;
                     I_p1 = other.I_p1;
                     S_ch = other.S_ch;
@@ -455,11 +455,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof danishStemmer;
+            return o instanceof DanishStemmer;
         }
 
         public int hashCode() {
-            return danishStemmer.class.getName().hashCode();
+            return DanishStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DutchStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DutchStemmer.java
index b402e4cfc..7819fe741 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/dutchStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/DutchStemmer.java
@@ -38,11 +38,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class dutchStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class DutchStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static dutchStemmer methodObject = new dutchStemmer ();
+        private final static DutchStemmer methodObject = new DutchStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 6, "", methodObject ),
@@ -104,7 +104,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private boolean B_e_found;
 
-                private void copy_from(dutchStemmer other) {
+                private void copy_from(DutchStemmer other) {
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
                     B_e_found = other.B_e_found;
@@ -869,11 +869,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof dutchStemmer;
+            return o instanceof DutchStemmer;
         }
 
         public int hashCode() {
-            return dutchStemmer.class.getName().hashCode();
+            return DutchStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/EnglishStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/EnglishStemmer.java
index 4323166b4..bba986b36 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/englishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/EnglishStemmer.java
@@ -38,11 +38,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * This class was automatically generated by a Snowball to Java compiler
  * It implements the stemming algorithm defined by a snowball script.
  */
-class englishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class EnglishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static englishStemmer methodObject = new englishStemmer ();
+        private final static EnglishStemmer methodObject = new EnglishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "arsen", -1, -1, "", methodObject ),
@@ -197,7 +197,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p2;
         private int I_p1;
 
-                private void copy_from(englishStemmer other) {
+                private void copy_from(EnglishStemmer other) {
                     B_Y_found = other.B_Y_found;
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
@@ -1346,11 +1346,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof englishStemmer;
+            return o instanceof EnglishStemmer;
         }
 
         public int hashCode() {
-            return englishStemmer.class.getName().hashCode();
+            return EnglishStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FinnishStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FinnishStemmer.java
index ba7215bca..cb8effd4c 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/finnishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FinnishStemmer.java
@@ -38,11 +38,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class finnishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class FinnishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static finnishStemmer methodObject = new finnishStemmer ();
+        private final static FinnishStemmer methodObject = new FinnishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "pa", -1, 1, "", methodObject ),
@@ -175,7 +175,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p2;
         private int I_p1;
 
-                private void copy_from(finnishStemmer other) {
+                private void copy_from(FinnishStemmer other) {
                     B_ending_removed = other.B_ending_removed;
                     S_x = other.S_x;
                     I_p2 = other.I_p2;
@@ -1066,11 +1066,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof finnishStemmer;
+            return o instanceof FinnishStemmer;
         }
 
         public int hashCode() {
-            return finnishStemmer.class.getName().hashCode();
+            return FinnishStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FrenchStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FrenchStemmer.java
index 8dd485a09..349deaaeb 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/frenchStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/FrenchStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class frenchStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class FrenchStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static frenchStemmer methodObject = new frenchStemmer ();
+        private final static FrenchStemmer methodObject = new FrenchStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "col", -1, -1, "", methodObject ),
@@ -224,7 +224,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private int I_pV;
 
-                private void copy_from(frenchStemmer other) {
+                private void copy_from(FrenchStemmer other) {
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
                     I_pV = other.I_pV;
@@ -1534,11 +1534,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof frenchStemmer;
+            return o instanceof FrenchStemmer;
         }
 
         public int hashCode() {
-            return frenchStemmer.class.getName().hashCode();
+            return FrenchStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/germanStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/GermanStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/germanStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/GermanStemmer.java
index f7c7938ae..1b57e68b0 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/germanStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/GermanStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class germanStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class GermanStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static germanStemmer methodObject = new germanStemmer ();
+        private final static GermanStemmer methodObject = new GermanStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 6, "", methodObject ),
@@ -97,7 +97,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p2;
         private int I_p1;
 
-                private void copy_from(germanStemmer other) {
+                private void copy_from(GermanStemmer other) {
                     I_x = other.I_x;
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
@@ -750,11 +750,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof germanStemmer;
+            return o instanceof GermanStemmer;
         }
 
         public int hashCode() {
-            return germanStemmer.class.getName().hashCode();
+            return GermanStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/hungarianStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/HungarianStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/hungarianStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/HungarianStemmer.java
index bb20a8500..00e85effd 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/hungarianStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/HungarianStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class hungarianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class HungarianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static hungarianStemmer methodObject = new hungarianStemmer ();
+        private final static HungarianStemmer methodObject = new HungarianStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "cs", -1, -1, "", methodObject ),
@@ -267,7 +267,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 
         private int I_p1;
 
-                private void copy_from(hungarianStemmer other) {
+                private void copy_from(HungarianStemmer other) {
                     I_p1 = other.I_p1;
                     super.copy_from(other);
                 }
@@ -1191,11 +1191,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof hungarianStemmer;
+            return o instanceof HungarianStemmer;
         }
 
         public int hashCode() {
-            return hungarianStemmer.class.getName().hashCode();
+            return HungarianStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/italianStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/ItalianStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/italianStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/ItalianStemmer.java
index 2159d09b2..58d14eee8 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/italianStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/ItalianStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class italianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class ItalianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static italianStemmer methodObject = new italianStemmer ();
+        private final static ItalianStemmer methodObject = new ItalianStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 7, "", methodObject ),
@@ -276,7 +276,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private int I_pV;
 
-                private void copy_from(italianStemmer other) {
+                private void copy_from(ItalianStemmer other) {
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
                     I_pV = other.I_pV;
@@ -1213,11 +1213,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof italianStemmer;
+            return o instanceof ItalianStemmer;
         }
 
         public int hashCode() {
-            return italianStemmer.class.getName().hashCode();
+            return ItalianStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/norwegianStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/NorwegianStemmer.java
similarity index 97%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/norwegianStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/NorwegianStemmer.java
index e38d599cb..f9f21c8d3 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/norwegianStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/NorwegianStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class norwegianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class NorwegianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static norwegianStemmer methodObject = new norwegianStemmer ();
+        private final static NorwegianStemmer methodObject = new NorwegianStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "a", -1, 1, "", methodObject ),
@@ -103,7 +103,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_x;
         private int I_p1;
 
-                private void copy_from(norwegianStemmer other) {
+                private void copy_from(NorwegianStemmer other) {
                     I_x = other.I_x;
                     I_p1 = other.I_p1;
                     super.copy_from(other);
@@ -391,11 +391,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof norwegianStemmer;
+            return o instanceof NorwegianStemmer;
         }
 
         public int hashCode() {
-            return norwegianStemmer.class.getName().hashCode();
+            return NorwegianStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/porterStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PorterStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/porterStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PorterStemmer.java
index 1fae1d4de..235ae2b59 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/porterStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PorterStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class porterStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class PorterStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static porterStemmer methodObject = new porterStemmer ();
+        private final static PorterStemmer methodObject = new PorterStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "s", -1, 3, "", methodObject ),
@@ -137,7 +137,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p2;
         private int I_p1;
 
-                private void copy_from(porterStemmer other) {
+                private void copy_from(PorterStemmer other) {
                     B_Y_found = other.B_Y_found;
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
@@ -939,11 +939,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof porterStemmer;
+            return o instanceof PorterStemmer;
         }
 
         public int hashCode() {
-            return porterStemmer.class.getName().hashCode();
+            return PorterStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/portugueseStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PortugueseStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/portugueseStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PortugueseStemmer.java
index c9942a656..bc8065e1a 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/portugueseStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/PortugueseStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class portugueseStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class PortugueseStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static portugueseStemmer methodObject = new portugueseStemmer ();
+        private final static PortugueseStemmer methodObject = new PortugueseStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 3, "", methodObject ),
@@ -270,7 +270,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private int I_pV;
 
-                private void copy_from(portugueseStemmer other) {
+                private void copy_from(PortugueseStemmer other) {
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
                     I_pV = other.I_pV;
@@ -1149,11 +1149,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof portugueseStemmer;
+            return o instanceof PortugueseStemmer;
         }
 
         public int hashCode() {
-            return portugueseStemmer.class.getName().hashCode();
+            return PortugueseStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/romanianStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RomanianStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/romanianStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RomanianStemmer.java
index ede5c49e2..69989bac8 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/romanianStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RomanianStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class romanianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class RomanianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static romanianStemmer methodObject = new romanianStemmer ();
+        private final static RomanianStemmer methodObject = new RomanianStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 3, "", methodObject ),
@@ -296,7 +296,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private int I_pV;
 
-                private void copy_from(romanianStemmer other) {
+                private void copy_from(RomanianStemmer other) {
                     B_standard_suffix_removed = other.B_standard_suffix_removed;
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
@@ -1057,11 +1057,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof romanianStemmer;
+            return o instanceof RomanianStemmer;
         }
 
         public int hashCode() {
-            return romanianStemmer.class.getName().hashCode();
+            return RomanianStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/russianStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RussianStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/russianStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RussianStemmer.java
index 1ffd0b74d..f317e0aa3 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/russianStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/RussianStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class russianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class RussianStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static russianStemmer methodObject = new russianStemmer ();
+        private final static RussianStemmer methodObject = new RussianStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "\u0432", -1, 1, "", methodObject ),
@@ -207,7 +207,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p2;
         private int I_pV;
 
-                private void copy_from(russianStemmer other) {
+                private void copy_from(RussianStemmer other) {
                     I_p2 = other.I_p2;
                     I_pV = other.I_pV;
                     super.copy_from(other);
@@ -760,11 +760,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof russianStemmer;
+            return o instanceof RussianStemmer;
         }
 
         public int hashCode() {
-            return russianStemmer.class.getName().hashCode();
+            return RussianStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java
index dd757548d..9572b32ee 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java
@@ -47,52 +47,52 @@ public SnowballStemmer(ALGORITHM algorithm, int repeat) {
     this.repeat = repeat;
 
     if (ALGORITHM.DANISH.equals(algorithm)) {
-      stemmer = new danishStemmer();
+      stemmer = new DanishStemmer();
     }
     else if (ALGORITHM.DUTCH.equals(algorithm)) {
-      stemmer = new dutchStemmer();
+      stemmer = new DutchStemmer();
     }
     else if (ALGORITHM.ENGLISH.equals(algorithm)) {
-      stemmer = new englishStemmer();
+      stemmer = new EnglishStemmer();
     }
     else if (ALGORITHM.FINNISH.equals(algorithm)) {
-      stemmer = new finnishStemmer();
+      stemmer = new FinnishStemmer();
     }
     else if (ALGORITHM.FRENCH.equals(algorithm)) {
-      stemmer = new frenchStemmer();
+      stemmer = new FrenchStemmer();
     }
     else if (ALGORITHM.GERMAN.equals(algorithm)) {
-      stemmer = new germanStemmer();
+      stemmer = new GermanStemmer();
     }
     else if (ALGORITHM.HUNGARIAN.equals(algorithm)) {
-      stemmer = new hungarianStemmer();
+      stemmer = new HungarianStemmer();
     }
     else if (ALGORITHM.ITALIAN.equals(algorithm)) {
-      stemmer = new italianStemmer();
+      stemmer = new ItalianStemmer();
     }
     else if (ALGORITHM.NORWEGIAN.equals(algorithm)) {
-      stemmer = new norwegianStemmer();
+      stemmer = new NorwegianStemmer();
     }
     else if (ALGORITHM.PORTER.equals(algorithm)) {
-      stemmer = new porterStemmer();
+      stemmer = new PorterStemmer();
     }
     else if (ALGORITHM.PORTUGUESE.equals(algorithm)) {
-      stemmer = new portugueseStemmer();
+      stemmer = new PortugueseStemmer();
     }
     else if (ALGORITHM.ROMANIAN.equals(algorithm)) {
-      stemmer = new romanianStemmer();
+      stemmer = new RomanianStemmer();
     }
     else if (ALGORITHM.RUSSIAN.equals(algorithm)) {
-      stemmer = new russianStemmer();
+      stemmer = new RussianStemmer();
     }
     else if (ALGORITHM.SPANISH.equals(algorithm)) {
-      stemmer = new spanishStemmer();
+      stemmer = new SpanishStemmer();
     }
     else if (ALGORITHM.SWEDISH.equals(algorithm)) {
-      stemmer = new swedishStemmer();
+      stemmer = new SwedishStemmer();
     }
     else if (ALGORITHM.TURKISH.equals(algorithm)) {
-      stemmer = new turkishStemmer();
+      stemmer = new TurkishStemmer();
     }
     else {
       throw new IllegalStateException("Unexpected stemmer algorithm: " + algorithm.toString());
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/spanishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SpanishStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/spanishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SpanishStemmer.java
index 1891e8e00..19e389bc4 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/spanishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SpanishStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class spanishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class SpanishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static spanishStemmer methodObject = new spanishStemmer ();
+        private final static SpanishStemmer methodObject = new SpanishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "", -1, 6, "", methodObject ),
@@ -283,7 +283,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_p1;
         private int I_pV;
 
-                private void copy_from(spanishStemmer other) {
+                private void copy_from(SpanishStemmer other) {
                     I_p2 = other.I_p2;
                     I_p1 = other.I_p1;
                     I_pV = other.I_pV;
@@ -1215,11 +1215,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof spanishStemmer;
+            return o instanceof SpanishStemmer;
         }
 
         public int hashCode() {
-            return spanishStemmer.class.getName().hashCode();
+            return SpanishStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/swedishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SwedishStemmer.java
similarity index 98%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/swedishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SwedishStemmer.java
index 56dab5c6f..10881565e 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/swedishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SwedishStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class swedishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class SwedishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static swedishStemmer methodObject = new swedishStemmer ();
+        private final static SwedishStemmer methodObject = new SwedishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "a", -1, 1, "", methodObject ),
@@ -110,7 +110,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private int I_x;
         private int I_p1;
 
-                private void copy_from(swedishStemmer other) {
+                private void copy_from(SwedishStemmer other) {
                     I_x = other.I_x;
                     I_p1 = other.I_p1;
                     super.copy_from(other);
@@ -382,11 +382,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof swedishStemmer;
+            return o instanceof SwedishStemmer;
         }
 
         public int hashCode() {
-            return swedishStemmer.class.getName().hashCode();
+            return SwedishStemmer.class.getName().hashCode();
         }
 
 
diff --git a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/turkishStemmer.java b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/TurkishStemmer.java
similarity index 99%
rename from opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/turkishStemmer.java
rename to opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/TurkishStemmer.java
index d4afbdb6a..bfedde827 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/turkishStemmer.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/TurkishStemmer.java
@@ -39,11 +39,11 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
   * This class was automatically generated by a Snowball to Java compiler
   * It implements the stemming algorithm defined by a snowball script.
   */
-class turkishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
+class TurkishStemmer extends opennlp.tools.stemmer.snowball.AbstractSnowballStemmer {
 
 private static final long serialVersionUID = 1L;
 
-        private final static turkishStemmer methodObject = new turkishStemmer ();
+        private final static TurkishStemmer methodObject = new TurkishStemmer ();
 
                 private final static Among a_0[] = {
                     new Among ( "m", -1, -1, "", methodObject ),
@@ -256,7 +256,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
         private boolean B_continue_stemming_noun_suffixes;
         private int I_strlen;
 
-                private void copy_from(turkishStemmer other) {
+                private void copy_from(TurkishStemmer other) {
                     B_continue_stemming_noun_suffixes = other.B_continue_stemming_noun_suffixes;
                     I_strlen = other.I_strlen;
                     super.copy_from(other);
@@ -3163,11 +3163,11 @@ public boolean stem() {
                 }
 
         public boolean equals( Object o ) {
-            return o instanceof turkishStemmer;
+            return o instanceof TurkishStemmer;
         }
 
         public int hashCode() {
-            return turkishStemmer.class.getName().hashCode();
+            return TurkishStemmer.class.getName().hashCode();
         }
 
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rename snowball stemmer classes for Java naming conformance
> -----------------------------------------------------------
>
>                 Key: OPENNLP-1049
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1049
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Stemmer
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Trivial
>
> Rename snowball stemmer classes for Java naming conformance, e.g. rename `turkishStemmer` to `TurkishStemmer`. This should not affect any implementations because all of the stemmers are accessed through the `SnowballStemmer()` constructor.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)