You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/01/16 15:06:35 UTC
[GitHub] [openwhisk-release] tardieu opened a new issue #317: Improve
gen-release-vote.py and document
tardieu opened a new issue #317: Improve gen-release-vote.py and document
URL: https://github.com/apache/openwhisk-release/issues/317
`gen-release-vote.py` expects the `refs/remotes/upstream/master` branch exists in the current clone.
https://github.com/apache/openwhisk-release/blob/master/tools/gen-release-vote.py#L91
This is not the case when using a simple clone of the `openwhisk-release` repo.
The script could use better documentation, e.g., an example invocation. See
https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md#initiate-a-release-vote.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-release] tardieu commented on issue #317: Improve
gen-release-vote.py and document
Posted by GitBox <gi...@apache.org>.
tardieu commented on issue #317: Improve gen-release-vote.py and document
URL: https://github.com/apache/openwhisk-release/issues/317#issuecomment-575195427
I think the `gen-release-vote.py` should simply the hash for the local clone, since it most likely contains the version of `rcverify.sh` used by the release manager.
On the other hand, the script could alert the user that the hash does not match the head of the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-release] tardieu edited a comment on issue #317: Improve
gen-release-vote.py and document
Posted by GitBox <gi...@apache.org>.
tardieu edited a comment on issue #317: Improve gen-release-vote.py and document
URL: https://github.com/apache/openwhisk-release/issues/317#issuecomment-575195427
I think the `gen-release-vote.py` should simply embed the hash for the local clone, since it most likely contains the version of `rcverify.sh` used by the release manager.
On the other hand, the script could alert the user that the hash does not match the head of the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services