You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 19:16:10 UTC

Re: Review Request 53769: CMake: Added -fPIC to leveldb build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53769/#review157120
-----------------------------------------------------------


Ship it!




Ship It!

- Alex Clemmer


On Nov. 15, 2016, 3:21 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53769/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 3:21 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-5792
>     https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Leveldb is built statically (this is not configurable).
> This supplies the `-fPIC` compiler option as well as the default
> options used by leveldb (`-O2 -g`).
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 770a3828a6e0ffaa4f185392fdc1a2152446449d 
> 
> Diff: https://reviews.apache.org/r/53769/diff/
> 
> 
> Testing
> -------
> 
> cmake ..
> make
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>