You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/29 13:35:51 UTC
[GitHub] [arrow] Dandandan opened a new pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Dandandan opened a new pull request #8800:
URL: https://github.com/apache/arrow/pull/8800
Speeds up sum kernel with nulls by simplifying mask calculation in inner loop.
```
sum nulls 512 time: [227.43 ns 227.73 ns 228.09 ns]
change: [-53.623% -53.506% -53.391%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-737022972
> Looks like an unrelated failure in the CI
The failure's indeed unrelated, it's something we subsequently fixed, but is still failing because it's not yet rebased in this PR.
@andygrove @alamb @jorgecarleitao may any of you please merge this, I won't be able to merge until my evening time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jhorstmann commented on pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-735656117
LGTM. I really would have expected the compiler to figure this out and do the optimization itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-736683582
Looks like an unrelated failure in the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-736605119
I've rerun the integration CI job, we can merge this after we get confirmation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8800:
URL: https://github.com/apache/arrow/pull/8800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8800: ARROW-10767: [Rust] Speed up sum with nulls (non-simd)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8800:
URL: https://github.com/apache/arrow/pull/8800#issuecomment-735397285
https://issues.apache.org/jira/browse/ARROW-10767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org