svn commit: r615843 - in /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core: persistence/bundle/BundleDbPersistenceManager.java persistence/bundle/util/ConnectionFactory.java query/sql2/Parser.java

[th...@apache.org]

Author: thomasm
Date: Mon Jan 28 02:25:51 2008
New Revision: 615843

URL: http://svn.apache.org/viewvc?rev=615843&view=rev
Log:
JCR-97: Improve Checkstyle conformance - add Javadoc comments

Modified:
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/BundleDbPersistenceManager.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java
    jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql2/Parser.java

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/BundleDbPersistenceManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/BundleDbPersistenceManager.java?rev=615843&r1=615842&r2=615843&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/BundleDbPersistenceManager.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/BundleDbPersistenceManager.java Mon Jan 28 02:25:51 2008
@@ -1427,6 +1427,10 @@
         }
     }
 
+    /**
+     * Iterator over an in-memory list of node ids.
+     * This helper class is used by {@link BundleDbPersistenceManager#getAllNodeIds()}.
+     */
     private class ListNodeIdIterator implements NodeIdIterator {
 
         private final ArrayList list;

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java?rev=615843&r1=615842&r2=615843&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/persistence/bundle/util/ConnectionFactory.java Mon Jan 28 02:25:51 2008
@@ -33,6 +33,12 @@
 public class ConnectionFactory {
 
     /**
+     * Utility classes should not have a public or default constructor.
+     */
+    private ConnectionFactory() {
+    }
+
+    /**
      * Open a connection using the specified properties.
      * The connection can be created using a JNDI Data Source as well. To do that,
      * the driver class name must reference a javax.naming.Context class

Modified: jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql2/Parser.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql2/Parser.java?rev=615843&r1=615842&r2=615843&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql2/Parser.java (original)
+++ jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/query/sql2/Parser.java Mon Jan 28 02:25:51 2008
@@ -321,7 +321,9 @@
             if (readIf("IS")) {
                 read("NULL");
                 if (!(left instanceof PropertyValue)) {
-                    throw new RepositoryException("Only property values can be tested for NOT IS NULL; got: " + left.getClass().getName());
+                    throw new RepositoryException(
+                            "Only property values can be tested for NOT IS NULL; got: "
+                            + left.getClass().getName());
                 }
                 PropertyValue pv = (PropertyValue) left;
                 c = getPropertyExistence(pv);
@@ -949,10 +951,14 @@
         return new InvalidQueryException("Query:\n" + query);
     }
 
+    /**
+     * Represents a column or a wildcard in a SQL expression.
+     * This class is temporarily used during parsing.
+     */
     private static class ColumnOrWildcard {
-        String selectorName;
-        String propertyName;
-        String columnName;
+        private String selectorName;
+        private String propertyName;
+        private String columnName;
     }
 
 }