You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/05 11:15:09 UTC

[PR] feat(skill): add pre-first-pr-check skill with eval suite [magpie]

justinmclean opened a new pull request, #752:
URL: https://github.com/apache/magpie/pull/752

   ## Summary
   
   Newcomer-facing Agentic Pairing skill that runs a pre-flight checklist on a contributor's local branch before opening a PR. Checks five categories: SPDX headers on new files, commit-message shape (imperative subject, no AI Co-Authored-By, Generated-by trailer for AI-assisted work), placeholder-convention compliance, CONTRIBUTING conventions, and prompt-injection guard. Read-only; returns a structured checklist report with pass/fail/advisory status per category.
   
   Ships a 9-case eval suite across two steps (step-2-check-categories and step-3-compose-report) covering clean branches, missing SPDX header, non-imperative commit subject, agent Co-Authored-By trailer, unsubstituted placeholders, and prompt-injection resistance.
   
   Updates docs/modes.md and docs/labels-and-capabilities.md to register the skill in the Pairing family (count 2 to 3).
   
   Note: item 2 (local-smoke-candidate-sweep) was skipped this iteration as ollama is installed but no model is pulled so the validation command cannot run. Item 4 (harness-posture-portability) is a flagged epic requiring decomposition before build.
   
   Generated-by: Claude (claude-sonnet-4-6)
   
   ## Type of change
   
   - [X] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
   - [ ] Tool / bridge contract (`tools/<system>/*.md`)
   - [ ] Python package (`tools/*/` with `pyproject.toml`)
   - [ ] Groovy reference impl
   - [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
   - [ ] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
   - [ ] Project template (`projects/_template/`)
   - [ ] CI / dev loop (`prek`, workflows, validators)
   - [ ] Other:
   
   ## Test plan
   
   - [X] `prek run --all-files` passes
   - [ ] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
   - [ ] For Groovy bridges touched: command-line invocation tested end-to-end
   - [X] For skill changes: eval suite passes for the affected skill
         (`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
   - [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
         (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
   - [ ] Other:
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(skill): add pre-first-pr-check skill with eval suite [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #752:
URL: https://github.com/apache/magpie/pull/752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org