You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/23 04:22:22 UTC
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #9123: Feature: add syntax for alter table in g4 files and unit tests, for 6480 issue.
wgy8283335 commented on a change in pull request #9123:
URL: https://github.com/apache/shardingsphere/pull/9123#discussion_r563015614
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -37,7 +37,7 @@ alterIndex
;
dropTable
- : DROP TABLE tableName (CASCADE CONSTRAINTS)? (PURGE)?
+ : DROP TABLE tableName
Review comment:
I've fixed this.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/Keyword.g4
##########
@@ -550,3 +550,7 @@ NUMERIC
FLOAT
: F L O A T
;
+
+TRIGGERS
+ : T R I G G E R S
+ ;
Review comment:
I've fixed this.
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/OracleKeyword.g4
##########
@@ -818,3 +818,11 @@ IDENTIFIER
WORK
: W O R K
;
+
+CONTAINER_MAP
+ : C O N T A I N E R UL_ M A P
+ ;
+
+CONTAINERS_DEFAULT
+ : C O N T A I N E R S UL_ D E F A U L T
+ ;
Review comment:
I've fixed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org