[GitHub] hboutemy commented on a change in pull request #233: [MNG-6562] added WARNING on default bindings plugins unlocked versions

[GitBox <gi...@apache.org>]

hboutemy commented on a change in pull request #233: [MNG-6562] added WARNING on default bindings plugins unlocked versions
URL: https://github.com/apache/maven/pull/233#discussion_r247787438
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/model/plugin/DefaultLifecycleBindingsInjector.java
 ##########
 @@ -87,18 +102,21 @@ else if ( !defaultPlugins.isEmpty() )
     {
 
         private static final String PLUGIN_MANAGEMENT = "plugin-management";
+        private static final String NO_VERSION_PLUGINS = "no-version-plugins";
 
-        public void merge( Model target, Model source )
+        public Collection<Plugin> merge( Model target, Model source )
 
 Review comment:
   true, I forgot to add at least a javadoc to explain the meaning of the return value, which was my minimal idea
   reading your comment, I just found another idea: let's pass ModelProblemCollector
   I like team work :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services