You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/01 05:32:06 UTC

[GitHub] [pulsar] nlu90 opened a new pull request #13059: pulsar admin exposes secret for source and sink

nlu90 opened a new pull request #13059:
URL: https://github.com/apache/pulsar/pull/13059


   ### Motivation
   Follow-up fix of #12950 for #12834 
   
   It turns out the Source and Sink doesn't inherit from Function cmd, so we need to add the api separately.
   
   ### Modifications
   
   add the `--secrets` argument into `pulsar-admin [source|sink] create/update/localrun` command
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - The public API:  new `--secrets` argument for submitting/updating sources/sinks
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [X] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #13059: pulsar admin exposes secret for source and sink

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13059:
URL: https://github.com/apache/pulsar/pull/13059


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #13059: pulsar admin exposes secret for source and sink

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13059:
URL: https://github.com/apache/pulsar/pull/13059#issuecomment-983442891


   For the doc side, I've confirmed w/ @freeznet, this PR is similar to https://github.com/apache/pulsar/pull/12950#issuecomment-977717237 
   
   Hi @nlu90 same comments for you: https://github.com/apache/pulsar/pull/12950#issuecomment-977679867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org