You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/10/05 02:02:34 UTC
mesos git commit: Fixed flag stringification bug in Linux filesystem
isolator.
Repository: mesos
Updated Branches:
refs/heads/master 512620afb -> b70a22bad
Fixed flag stringification bug in Linux filesystem isolator.
To stringify a `Flag` we are required to pass the `Flags` instance
actually holding the `Flag` to `Flag::stringify`.
This patch fixes the incorrect call to `flag.stringify(flags)`.
Since we iterate over `mountFlags`, we should have been invoking
`flag.stringify(mountFlags)` instead.
Review: https://reviews.apache.org/r/52385/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b70a22ba
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b70a22ba
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b70a22ba
Branch: refs/heads/master
Commit: b70a22bad22e5e8668f9af62c575902dec7b0125
Parents: 512620a
Author: Benjamin Bannier <be...@mesosphere.io>
Authored: Tue Oct 4 21:51:01 2016 -0400
Committer: Michael Park <mp...@apache.org>
Committed: Tue Oct 4 21:51:01 2016 -0400
----------------------------------------------------------------------
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/b70a22ba/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp b/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
index e55f3d1..8f62162 100644
--- a/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
+++ b/src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
@@ -373,7 +373,7 @@ Try<vector<CommandInfo>> LinuxFilesystemIsolatorProcess::getPreExecCommands(
mountFlags.path = "/";
foreachvalue (const flags::Flag& flag, mountFlags) {
- const Option<string> value = flag.stringify(flags);
+ const Option<string> value = flag.stringify(mountFlags);
if (value.isSome()) {
command.add_arguments(
"--" + flag.effective_name().value + "=" + value.get());