[jira] [Updated] (LUCENE-5472) Long terms should generate a RuntimeException, not just infoStream

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated LUCENE-5472:
-----------------------------

    Attachment: LUCENE-5472.patch

bq. I would prefer we just change it in trunk and 4.x, rather than something tricky.

Works for me -- we can note it in the backcompat section

bq. Added Solr Tests 

Thanks for writing those tests Varun!

I've tweaked the patch slightly...

* renamed Varun's Solr TestIndexing -> TestExceedMaxTermLength so it's more clear what we're testing
* fixed a variable typo in the test (longFielValue -> longFieldValue)
* fixed patch so that "ant precommit" would pass (String.format was being used w/o a Locale)
* removed a stale nocommit comment i'd put in lucene's TestExceedMaxTermLength that Mike fixed a few patches ago
* fixed the jdocs for IndexWriter.addDocument to refer to MAX_TERM_LENGTH (ironically it already incorrectly said that terms which were too long would cause an IllegalArgumentException

I think this is ready? speak now or i'll commit tomorrow.


> Long terms should generate a RuntimeException, not just infoStream
> ------------------------------------------------------------------
>
>                 Key: LUCENE-5472
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5472
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: LUCENE-5472.patch, LUCENE-5472.patch, LUCENE-5472.patch, LUCENE-5472.patch
>
>
> As reported on the solr-user list, when a term is greater then 2^15 bytes it is silently ignored at indexing time -- a message is logged in to infoStream if enabled, but no error is thrown.
> seems like we should change this behavior (if nothing else starting in 5.0) to throw an exception.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org