[jira] [Comment Edited] (SOLR-15222) Solr should not auto-create the "userfiles" dir

["Jason Gerlowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305112#comment-17305112 ] 

Jason Gerlowski edited comment on SOLR-15222 at 3/19/21, 6:41 PM:
------------------------------------------------------------------

bq. Would it be possible to create the directory the first time someone tries to upload a file to the "filestore"?

No, "userfiles" is a different location and mechanism from the "blobstore"/"filestore".  I think the latter has APIs for uploading files, etc. but "userfiles" definitely doesn't.  So there's no good place to add lazy-creation logic here.

Similarly, SOLR-15268 isn't related.  Afaict that ticket is about the blobstore/filestore, and this issue is specific to "userfiles".

----

In terms of how to tackle this issue, I'd vote for an option David mentioned in his description: let's switch the features that use "userfiles" currently over to using the blobstore.  That sidesteps the eager/lazy creation question nicely by removing the directory from Solr features entirely.


was (Author: gerlowskija):
bq. Would it be possible to create the directory the first time someone tries to upload a file to the "filestore"?

No, "userfiles" is a different location and mechanism from the "blobstore"/"filestore".  I think the latter has APIs for uploading files, etc. but "userfiles" definitely doesn't.  So there's no good place to add lazy-creation logic here.

Similarly, SOLR-15268 isn't related.  Afaict that ticket is about the blobstore/filestore, and this issue is specific to "userfiles".



> Solr should not auto-create the "userfiles" dir
> -----------------------------------------------
>
>                 Key: SOLR-15222
>                 URL: https://issues.apache.org/jira/browse/SOLR-15222
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Major
>
> The "userfiles" feature is relatively obscure and might be subsumed by the "file store".  I don't think an obscure feature should be auto-creating its "userfiles" directory.  Even a popular one; not sure it makes sense.  If a user wants to use this feature, they are welcome to create the directory.  Solr has other optional directories, like solr-home/lib that are not auto-created; it's not clear to me why this one is.  I've found the auto-creation of this dir to be annoying in two ways.  One is in Solr's tests – there are existing Jira issues that show stack traces about this even though it's ignored.  Secondly is as a down-stream consumer for running/building Solr plugins that have a Solr home dir pointing somewhere that suddenly has this userfiles dir popping up despite me having no plans to use it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)