[GitHub] [shiro] bmarwell commented on issue #1005: Expand checkstyle to all modules (root)

["bmarwell (via GitHub)" <gi...@apache.org>]

bmarwell commented on issue #1005:
URL: https://github.com/apache/shiro/issues/1005#issuecomment-1634767597

   Hi @EdgarRamirezFuentes 
   
   Probably an `inherit` parameter is enough between the version and the config right here: https://github.com/apache/shiro/blob/main/pom.xml#L543-L546
   
   But haven't looked into it, as I am in a rush right now.
   
   If it works, you should get a message that checkstyle was executed for every module when running `mvn verify` on Shiro. It will probably break something too.
   
   If you get to that point, create the PR and point out what did break and why. If there's just small fixes needed (eg whitespace changes), just do a second commit with the fixes. In any other case, we *might* want to exclude some modules from checking or just do a big "fix up all" commit and add it to [a special ignore file](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view). Yes, the commit to that file needs to be a separate one. :) 
   
   HTH to get you started!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@shiro.apache.org
For additional commands, e-mail: issues-help@shiro.apache.org