You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/24 03:44:58 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3670: ARTEMIS-3401 use regex on web console for DLQ & expiry
jbertram opened a new pull request #3670:
URL: https://github.com/apache/activemq-artemis/pull/3670
Currently dead-letter and expiry addresses can only be identified on the
web console if they perfectly match a configurable string value (i.e.
"DLQ" and "ExpiryQueue" by default respectively). However, lots of users
have multiple dead-letter and expiry addresses which follow the same
naming pattern. The web console should support using a regular
expression so all of these addresses can be properly identified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3670: ARTEMIS-3401 use regex on web console for DLQ & expiry
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3670:
URL: https://github.com/apache/activemq-artemis/pull/3670#issuecomment-891988021
I have no way to verify this. I will just trust you..
It would be great if a test was added using the framework done by @brusdev some time ago.. but it could be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3670: ARTEMIS-3401 use regex on web console for DLQ & expiry
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3670:
URL: https://github.com/apache/activemq-artemis/pull/3670#issuecomment-886766248
Inspecting the messages for `Message.HDR_ORIGINAL_ADDRESS` *might* work. I'm not sure if that header is stripped when the message is actually retried so you might encounter a weird situation where messages on the original queue can be retried.
I'm not sure how using `getAddressSettingsAsJSON` would work here as there's no "reverse lookup" where you can submit a `dead-letter-address` value and get back the address names which match. I think you'd have to do some kind of brute force search by first invoking `getAddressNames` and then taking every individual address name and using `getAddressSettingsAsJSON` to see if `dead-letter-address` or `expiry-address` matched the value you're looking for. Also, there's the complication of auto-created dead-letter and expiry resources which use a prefix and/or suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on pull request #3670: ARTEMIS-3401 use regex on web console for DLQ & expiry
Posted by GitBox <gi...@apache.org>.
brusdev commented on pull request #3670:
URL: https://github.com/apache/activemq-artemis/pull/3670#issuecomment-886436027
Could the retry button be enabled for all messages with the `Message.HDR_ORIGINAL_ADDRESS` property or for all addresses matching with the `DLQ`/`expiryAddress` value of another address getAddressSettingsAsJSON ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3670: ARTEMIS-3401 use regex on web console for DLQ & expiry
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3670:
URL: https://github.com/apache/activemq-artemis/pull/3670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org