You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "abeizn (via GitHub)" <gi...@apache.org> on 2023/09/13 10:14:04 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #6078: fix: jira incremental collectors
abeizn opened a new pull request, #6078:
URL: https://github.com/apache/incubator-devlake/pull/6078
### Summary
fix some plugins incremental collectors
### Does this close any open issues?
Closes #6075
### Screenshots
jira:
first collect and the timeAfter="2023-03-12 16:00:00 +0000 UTC"
second collect:
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on a diff in pull request #6078: fix: jira/jenkins/github/tapd incremental collectors
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #6078:
URL: https://github.com/apache/incubator-devlake/pull/6078#discussion_r1325525371
##########
backend/plugins/github/tasks/pr_review_comment_collector.go:
##########
@@ -77,11 +76,11 @@ func CollectPrReviewComments(taskCtx plugin.SubTaskContext) errors.Error {
UrlTemplate: "repos/{{ .Params.Name }}/pulls/comments",
Query: func(reqData *helper.RequestData) (url.Values, errors.Error) {
query := url.Values{}
- if syncPolicy != nil && syncPolicy.TimeAfter != nil {
+ if collectorWithState.TimeAfter != nil {
// Note that `since` is for filtering records by the `updated` time
// which is not ideal for semantic reasons and would result in slightly more records than expected.
// But we have no choice since it is the only available field we could exploit from the API.
Review Comment:
delete
##########
backend/plugins/github/tasks/comment_collector.go:
##########
@@ -69,11 +68,11 @@ func CollectApiComments(taskCtx plugin.SubTaskContext) errors.Error {
Query: func(reqData *helper.RequestData) (url.Values, errors.Error) {
query := url.Values{}
query.Set("state", "all")
- if syncPolicy != nil && syncPolicy.TimeAfter != nil {
+ if collectorWithState.TimeAfter != nil {
// Note that `since` is for filtering records by the `updated` time
// which is not ideal for semantic reasons and would result in slightly more records than expected.
// But we have no choice since it is the only available field we could exploit from the API.
Review Comment:
These 2 lines of comments should be deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh merged pull request #6078: fix: jira/jenkins/github/tapd incremental collectors
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #6078:
URL: https://github.com/apache/incubator-devlake/pull/6078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org