You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/04/28 03:21:55 UTC
Review Request 46756: V1 API: Split Resource offers and Inverse
Offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46756/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.
Bugs: MESOS-5296
https://issues.apache.org/jira/browse/MESOS-5296
Repository: mesos
Description
-------
V1 API: Split Resource offers and Inverse Offers.
Diffs
-----
include/mesos/scheduler/scheduler.proto 078c6550f24a3d8ac675251168434130fc3eeef3
include/mesos/v1/scheduler/scheduler.proto 8ed9e19a9e5aa19a518b708b0e0d9cfdc038cd11
src/cli/execute.cpp 370e9f4924514077bb816c537261b9070658ddfb
src/examples/long_lived_framework.cpp 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65
src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5
src/internal/evolve.hpp cff6b657a6d69ff9e7f7dedc965122a03a200da1
src/internal/evolve.cpp 4ca2abacd75523de8fb4ffe69a9edd8627f512af
src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d
src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c
src/sched/sched.cpp a1ec280222689a05e9a0241ec5c84277a25b0866
src/tests/master_maintenance_tests.cpp 971c4473acbec5206614f46f51b06b3460595d50
src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2
Diff: https://reviews.apache.org/r/46756/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 46756: V1 API: Split Resource offers and Inverse
Offers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46756/#review131172
-----------------------------------------------------------
Fix it, then Ship it!
LGTM!
include/mesos/scheduler/scheduler.proto (lines 79 - 80)
<https://reviews.apache.org/r/46756/#comment195095>
Now that we've got a separate Event, it might be more precise to replace "a set of resources" with something like:
```
Each inverse offer specifies the agent and potentially some specific resources.
```
The reason being that the default implementation only fills in the AgentID.
- Joseph Wu
On April 27, 2016, 6:21 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46756/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 6:21 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-5296
> https://issues.apache.org/jira/browse/MESOS-5296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> V1 API: Split Resource offers and Inverse Offers.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 078c6550f24a3d8ac675251168434130fc3eeef3
> include/mesos/v1/scheduler/scheduler.proto 8ed9e19a9e5aa19a518b708b0e0d9cfdc038cd11
> src/cli/execute.cpp 370e9f4924514077bb816c537261b9070658ddfb
> src/examples/long_lived_framework.cpp 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65
> src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5
> src/internal/evolve.hpp cff6b657a6d69ff9e7f7dedc965122a03a200da1
> src/internal/evolve.cpp 4ca2abacd75523de8fb4ffe69a9edd8627f512af
> src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d
> src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c
> src/sched/sched.cpp a1ec280222689a05e9a0241ec5c84277a25b0866
> src/tests/master_maintenance_tests.cpp 971c4473acbec5206614f46f51b06b3460595d50
> src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2
>
> Diff: https://reviews.apache.org/r/46756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 46756: V1 API: Split Resource offers and Inverse
Offers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46756/#review130971
-----------------------------------------------------------
src/messages/messages.proto (line 267)
<https://reviews.apache.org/r/46756/#comment194877>
I think we should say somewhere that this is only sent to schedulers using the V1 HTTP API and not the driver based schedulers.
src/tests/mesos.hpp (line 957)
<https://reviews.apache.org/r/46756/#comment194878>
why snake case here?
- Vinod Kone
On April 28, 2016, 1:21 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46756/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:21 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.
>
>
> Bugs: MESOS-5296
> https://issues.apache.org/jira/browse/MESOS-5296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> V1 API: Split Resource offers and Inverse Offers.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 078c6550f24a3d8ac675251168434130fc3eeef3
> include/mesos/v1/scheduler/scheduler.proto 8ed9e19a9e5aa19a518b708b0e0d9cfdc038cd11
> src/cli/execute.cpp 370e9f4924514077bb816c537261b9070658ddfb
> src/examples/long_lived_framework.cpp 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65
> src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5
> src/internal/evolve.hpp cff6b657a6d69ff9e7f7dedc965122a03a200da1
> src/internal/evolve.cpp 4ca2abacd75523de8fb4ffe69a9edd8627f512af
> src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d
> src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c
> src/sched/sched.cpp a1ec280222689a05e9a0241ec5c84277a25b0866
> src/tests/master_maintenance_tests.cpp 971c4473acbec5206614f46f51b06b3460595d50
> src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2
>
> Diff: https://reviews.apache.org/r/46756/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>