You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "suryaprasanna (via GitHub)" <gi...@apache.org> on 2026/03/28 07:12:32 UTC

[PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

suryaprasanna opened a new pull request, #18408:
URL: https://github.com/apache/hudi/pull/18408

   …iles
   
   ### Describe the issue this Pull Request addresses
   
   Archived timeline reads could surface duplicate instants when both the original archive file and a leftover merged archive file were present after a failed archive merge operation.
   
   ### Summary and Changelog
   
   Adds a regression test covering leftover merged archive files in archived timeline loading.
   
   Updates archived timeline instant collection to avoid adding duplicate instants while preserving valid cases where different actions share the same timestamp.
   
   ### Impact
   
   Fixes archived timeline loading so duplicate instants are not returned in this leftover archive file scenario. No public API changes.
   
   ### Risk Level
   
   low
   
   The change is localized to archived timeline loading in V1 and is covered by a targeted regression test for the failed merge / leftover file case.
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185172698

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4ecd92708329d7a3523d63fdff156c12d25b09f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185164151

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51623cdec56ba782d8aa2904ac753c7922a6a377 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897) 
   * 4ecd92708329d7a3523d63fdff156c12d25b09f9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4201299095

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 795be190533a70b9c9354db902730375a1ee79bc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061) 
   * 05f4bc9192dc54b9934318e32f4fe484fb3fe6c8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147582977

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.33%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.33%   -0.89%     
   + Complexity    27709    27349     -360     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90395    -1183     
   - Misses        35565    36693    +1128     
   - Partials       7106     7162      +56     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <0.00%> (-3.73%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.06%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [162 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147568034

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.18%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.18%   -7.03%     
   + Complexity    27709    24818    -2891     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    82144    -9434     
   - Misses        35565    45202    +9637     
   + Partials       7106     6904     -202     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <0.00%> (-15.73%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147609917

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.22%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18408   +/-   ##
   =========================================
     Coverage     68.21%   68.22%           
   + Complexity    27709    27703    -6     
   =========================================
     Files          2440     2440           
     Lines        134249   134250    +1     
     Branches      16179    16182    +3     
   =========================================
   + Hits          91578    91590   +12     
   + Misses        35565    35557    -8     
   + Partials       7106     7103    -3     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <0.00%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185328544

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 45.28%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   45.28%   -22.93%     
   + Complexity    27709    15489    -12220     
   =============================================
     Files          2440     1998      -442     
     Lines        134249   111526    -22723     
     Branches      16179    14118     -2061     
   =============================================
   - Hits          91578    50509    -41069     
   - Misses        35565    55603    +20038     
   + Partials       7106     5414     -1692     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.59%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1569 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185367321

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.28%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   66.28%   -1.93%     
   + Complexity    27709    26963     -746     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    89110    -2468     
   - Misses        35565    37870    +2305     
   - Partials       7106     7445     +339     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <0.00%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <75.00%> (+0.23%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [397 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185386640

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185411697

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.53%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92412     +834     
   + Misses        35565    34731     -834     
   - Partials       7106     7282     +176     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <0.00%> (+0.05%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202478796

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 53.91%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   53.91%   -14.30%     
   + Complexity    27709    12258    -15451     
   =============================================
     Files          2440     1425     -1015     
     Lines        134249    70882    -63367     
     Branches      16179     7992     -8187     
   =============================================
   - Hits          91578    38217    -53361     
   + Misses        35565    29246     -6319     
   + Partials       7106     3419     -3687     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1796 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3048287374


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,8 +320,10 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        List<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>());
+        if (!instantsForTime.contains(instant.get())) {
+          instantsForTime.add(instant.get());

Review Comment:
   🤖 `ConcurrentHashMap.newKeySet()` is already O(1) for add/contains, which is more efficient than TreeSet's O(log n). Since the downstream code applies `.sorted()` on the flattened stream anyway, there's no benefit to maintaining sorted order in the set itself. Plus `ConcurrentHashMap.newKeySet()` is thread-safe, matching the concurrency expectations of the outer `ConcurrentHashMap`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202544831

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.29%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.29%   -6.93%     
   + Complexity    27709    24997    -2712     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    82768    -8810     
   - Misses        35565    45294    +9729     
   + Partials       7106     6972     -134     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [603 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202589267

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.80%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.80%   -0.42%     
   + Complexity    27709    27695      -14     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    91558      -20     
   - Misses        35565    36079     +514     
   - Partials       7106     7397     +291     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <0.00%> (-3.61%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.34% <100.00%> (+0.10%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [257 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147565393

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.63%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 19 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|2|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   58.63%   -9.58%     
   + Complexity    27709    23844    -3865     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    78724   -12854     
   - Misses        35565    48768   +13203     
   + Partials       7106     6758     -348     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <0.00%> (-15.33%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [656 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147560062

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 45.71%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   45.71%   -22.51%     
   + Complexity    27709    15211    -12498     
   =============================================
     Files          2440     1967      -473     
     Lines        134249   108493    -25756     
     Branches      16179    13468     -2711     
   =============================================
   - Hits          91578    49594    -41984     
   - Misses        35565    53694    +18129     
   + Partials       7106     5205     -1901     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <0.00%> (-12.45%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147567673

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.67%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   58.67%   -9.55%     
   + Complexity    27709    23858    -3851     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    78765   -12813     
   - Misses        35565    48733   +13168     
   + Partials       7106     6752     -354     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <0.00%> (-15.73%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [655 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147587841

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.41%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.41%   -0.81%     
   + Complexity    27709    27385     -324     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90502    -1076     
   - Misses        35565    36584    +1019     
   - Partials       7106     7164      +58     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.08% <0.00%> (-3.63%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [143 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202332178

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13136",
       "triggerID" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05f4bc9192dc54b9934318e32f4fe484fb3fe6c8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129) 
   * a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13136) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185390882

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202643373

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.77%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.77%   +0.56%     
   - Complexity    27709    28118     +409     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92874    +1296     
   + Misses        35565    34799     -766     
   - Partials       7106     7361     +255     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.84% <0.00%> (+0.13%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202607062

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.72%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.72%   +0.50%     
   - Complexity    27709    28077     +368     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92801    +1223     
   + Misses        35565    34852     -713     
   - Partials       7106     7381     +275     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.71% <0.00%> (+<0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [136 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202591792

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.92%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.92%   -0.29%     
   - Complexity    27709    27764      +55     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    91724     +146     
   - Misses        35565    35871     +306     
   - Partials       7106     7439     +333     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [246 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202315836

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05f4bc9192dc54b9934318e32f4fe484fb3fe6c8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129) 
   * a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202534451

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.27%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.27%   -6.94%     
   + Complexity    27709    24987    -2722     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135020     +771     
     Branches      16179    16374     +195     
   ============================================
   - Hits          91578    82735    -8843     
   - Misses        35565    45309    +9744     
   + Partials       7106     6976     -130     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <0.00%> (-15.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [603 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202540431

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.29%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.29%   -6.93%     
   + Complexity    27709    24997    -2712     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    82768    -8810     
   - Misses        35565    45294    +9729     
   + Partials       7106     6972     -134     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [603 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3007012038


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,8 +320,10 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        List<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>());
+        if (!instantsForTime.contains(instant.get())) {
+          instantsForTime.add(instant.get());

Review Comment:
   should we use `TreeSet` to keep the lookup efficient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147562299

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.00%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   48.00%   -20.21%     
   + Complexity    27709    16305    -11404     
   =============================================
     Files          2440     1996      -444     
     Lines        134249   111061    -23188     
     Branches      16179    14013     -2166     
   =============================================
   - Hits          91578    53319    -38259     
   - Misses        35565    52167    +16602     
   + Partials       7106     5575     -1531     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <0.00%> (-14.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1511 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147571230

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.21%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.21%   -7.01%     
   + Complexity    27709    24829    -2880     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    82178    -9400     
   - Misses        35565    45173    +9608     
   + Partials       7106     6899     -207     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-16.16%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147555687

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 53.87%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   53.87%   -14.34%     
   + Complexity    27709    12185    -15524     
   =============================================
     Files          2440     1424     -1016     
     Lines        134249    70444    -63805     
     Branches      16179     7899     -8280     
   =============================================
   - Hits          91578    37955    -53623     
   + Misses        35565    29119     -6446     
   + Partials       7106     3370     -3736     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1790 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185418887

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.53%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92414     +836     
   + Misses        35565    34729     -836     
   - Partials       7106     7282     +176     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <0.00%> (+0.05%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [113 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185299174

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 54.00%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   54.00%   -14.22%     
   + Complexity    27709    12247    -15462     
   =============================================
     Files          2440     1424     -1016     
     Lines        134249    70705    -63544     
     Branches      16179     7952     -8227     
   =============================================
   - Hits          91578    38181    -53397     
   + Misses        35565    29109     -6456     
   + Partials       7106     3415     -3691     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1793 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185392627

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147582536

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.31%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.31%   -0.91%     
   + Complexity    27709    27343     -366     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90365    -1213     
   - Misses        35565    36718    +1153     
   - Partials       7106     7167      +61     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <0.00%> (-3.81%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.06%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [169 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147582747

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.31%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.31%   -0.91%     
   + Complexity    27709    27343     -366     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90365    -1213     
   - Misses        35565    36718    +1153     
   - Partials       7106     7167      +61     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <0.00%> (-3.81%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <66.66%> (-0.06%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [169 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3048801346


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,8 +320,10 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        List<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>());
+        if (!instantsForTime.contains(instant.get())) {
+          instantsForTime.add(instant.get());

Review Comment:
   🤖 Since both call sites (`loadInstants` and `loadAndCacheInstantsWithLimit`) already call `.sorted()` after flattening the values, ordering within each bucket doesn't matter. `ConcurrentHashMap.newKeySet()` gives O(1) add/contains and is also thread-safe for concurrent `accept()` calls, which `TreeSet` would not be without external synchronization. I think the current choice is appropriate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185338868

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.16%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   48.16%   -20.05%     
   + Complexity    27709    16421    -11288     
   =============================================
     Files          2440     1998      -442     
     Lines        134249   111526    -22723     
     Branches      16179    14118     -2061     
   =============================================
   - Hits          91578    53720    -37858     
   - Misses        35565    52195    +16630     
   + Partials       7106     5611     -1495     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <0.00%> (-15.83%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.59%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185345682

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.91%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   58.91%   -9.30%     
   + Complexity    27709    24001    -3708     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    79203   -12375     
   - Misses        35565    48455   +12890     
   + Partials       7106     6767     -339     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <0.00%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.59%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [702 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185378703

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.90%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.90%   -0.32%     
   + Complexity    27709    27705       -4     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    91278     -300     
   - Misses        35565    35793     +228     
   - Partials       7106     7354     +248     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <0.00%> (-3.68%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [236 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4201545118

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.43%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05f4bc9`](https://app.codecov.io/gh/apache/hudi/commit/05f4bc9192dc54b9934318e32f4fe484fb3fe6c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (05f4bc9). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (05f4bc9) |
   >|------|------|------|
   >|hadoop-mr-java-client|1|0|
   >|spark-scala-tests|10|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-java-tests|15|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   44.43%   -23.79%     
   + Complexity    27709    16972    -10737     
   =============================================
     Files          2440     2388       -52     
     Lines        134249   127664     -6585     
     Branches      16179    14723     -1456     
   =============================================
   - Hits          91578    56723    -34855     
   - Misses        35565    66078    +30513     
   + Partials       7106     4863     -2243     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.10%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `1.38% <0.00%> (-76.39%)` | :arrow_down: |
   
   ... and [1246 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202646671

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.77%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.77%   +0.56%     
   - Complexity    27709    28118     +409     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92875    +1297     
   + Misses        35565    34799     -766     
   - Partials       7106     7360     +254     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.87% <0.00%> (+0.16%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147562148

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.00%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   48.00%   -20.21%     
   + Complexity    27709    16305    -11404     
   =============================================
     Files          2440     1996      -444     
     Lines        134249   111061    -23188     
     Branches      16179    14013     -2166     
   =============================================
   - Hits          91578    53319    -38259     
   - Misses        35565    52167    +16602     
   + Partials       7106     5575     -1531     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <0.00%> (-14.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1511 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147581578

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.23%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.23%   -0.98%     
   + Complexity    27709    27325     -384     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90266    -1312     
   - Misses        35565    36798    +1233     
   - Partials       7106     7186      +80     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <0.00%> (-3.81%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <66.66%> (-0.19%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [196 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147587448

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.38%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.38%   -0.83%     
   + Complexity    27709    27371     -338     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90465    -1113     
   - Misses        35565    36621    +1056     
   - Partials       7106     7164      +58     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <0.00%> (-3.69%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147589209

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.21%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   68.21%   -0.01%     
   + Complexity    27709    27701       -8     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    91574       -4     
   - Misses        35565    35569       +4     
   - Partials       7106     7107       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <0.00%> (-0.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3034719761


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,12 +321,14 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {

Review Comment:
   🤖 The `HashSet` returned by `computeIfAbsent` isn't thread-safe, but `accept()` is invoked from a parallel stream in `ArchivedTimelineLoaderV1` (line 136). Two threads processing instants with the same `requestedTime` can concurrently mutate the same `HashSet`, which risks corrupting its internal hash table (potentially causing infinite loops on resize). The prior `ArrayList` had the same issue, but the switch to `HashSet` makes it more acute since this PR's scenario (duplicate instants from merged files) increases the chance of same-key collisions. Could you use `Collections.newSetFromMap(new ConcurrentHashMap<>())` or `ConcurrentHashMap.newKeySet()` as the per-key set?



##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,12 +321,14 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        Set<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new HashSet<>());

Review Comment:
   🤖 nit: `Set.add()` is already a no-op when the element is present — the `contains` guard is redundant. You can simplify to just `instantsForTime.add(instant.get());`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185600226

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 795be190533a70b9c9354db902730375a1ee79bc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185381399

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4ecd92708329d7a3523d63fdff156c12d25b09f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056) 
   * 795be190533a70b9c9354db902730375a1ee79bc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185396499

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202605020

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.72%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.72%   +0.50%     
   - Complexity    27709    28076     +367     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92799    +1221     
   + Misses        35565    34853     -712     
   - Partials       7106     7382     +276     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <0.00%> (-0.06%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [136 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202564255

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 65.88%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   65.88%   -2.34%     
   + Complexity    27709    26878     -831     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    88966    -2612     
   - Misses        35565    38636    +3071     
   - Partials       7106     7432     +326     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.35% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <100.00%> (-0.29%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [441 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4201779444

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05f4bc9192dc54b9934318e32f4fe484fb3fe6c8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202499121

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 49.66%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   49.66%   -18.56%     
   + Complexity    27709    15882    -11827     
   =============================================
     Files          2440     1940      -500     
     Lines        134249   104632    -29617     
     Branches      16179    12606     -3573     
   =============================================
   - Hits          91578    51962    -39616     
   - Misses        35565    47431    +11866     
   + Partials       7106     5239     -1867     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <0.00%> (-15.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.14%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1583 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147557439

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 46.76%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   46.76%   -21.45%     
   + Complexity    27709    14889    -12820     
   =============================================
     Files          2440     1933      -507     
     Lines        134249   103681    -30568     
     Branches      16179    12415     -3764     
   =============================================
   - Hits          91578    48491    -43087     
   - Misses        35565    50236    +14671     
   + Partials       7106     4954     -2152     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.23% <0.00%> (-12.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1615 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147579283

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.18%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.18%   -1.03%     
   + Complexity    27709    27306     -403     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90199    -1379     
   - Misses        35565    36870    +1305     
   - Partials       7106     7181      +75     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <0.00%> (-3.81%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <66.66%> (-0.29%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [207 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147607456

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.22%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18408   +/-   ##
   =========================================
     Coverage     68.21%   68.22%           
   + Complexity    27709    27703    -6     
   =========================================
     Files          2440     2440           
     Lines        134249   134250    +1     
     Branches      16179    16182    +3     
   =========================================
   + Hits          91578    91588   +10     
   + Misses        35565    35558    -7     
   + Partials       7106     7104    -2     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <0.00%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202595919

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.92%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.92%   -0.29%     
   - Complexity    27709    27764      +55     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    91727     +149     
   - Misses        35565    35870     +305     
   - Partials       7106     7437     +331     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.56%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [245 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202582917

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.67%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.67%   -0.55%     
   + Complexity    27709    27632      -77     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    91383     -195     
   - Misses        35565    36276     +711     
   - Partials       7106     7375     +269     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <0.00%> (-3.61%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <100.00%> (-0.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [275 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202581373

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.67%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.67%   -0.55%     
   + Complexity    27709    27632      -77     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   - Hits          91578    91383     -195     
   - Misses        35565    36276     +711     
   - Partials       7106     7375     +269     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <0.00%> (-3.61%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <100.00%> (-0.11%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [275 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3048731412


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,8 +320,10 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        List<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>());
+        if (!instantsForTime.contains(instant.get())) {
+          instantsForTime.add(instant.get());

Review Comment:
   🤖 I think `ConcurrentHashMap.newKeySet()` is actually the better choice here — it gives O(1) for `add` and `contains`, whereas `TreeSet` would be O(log n) and would also need external synchronization (e.g. `Collections.synchronizedSortedSet`). Since the results are sorted downstream via `.sorted()` in the stream pipeline, there's no benefit to maintaining order within the set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185182296

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4ecd92708329d7a3523d63fdff156c12d25b09f9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056) 
   * 795be190533a70b9c9354db902730375a1ee79bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185386103

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185410490

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147592110

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.21%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   68.21%   -0.01%     
   + Complexity    27709    27702       -7     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
     Hits          91578    91578              
   - Misses        35565    35568       +3     
   + Partials       7106     7104       -2     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <0.00%> (-0.08%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147495869

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51623cdec56ba782d8aa2904ac753c7922a6a377 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147563802

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.59%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   58.59%   -9.62%     
   + Complexity    27709    23828    -3881     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    78664   -12914     
   - Misses        35565    48818   +13253     
   + Partials       7106     6768     -338     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <0.00%> (-14.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [656 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147559066

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 46.28%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 25 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   46.28%   -21.94%     
   + Complexity    27709    15051    -12658     
   =============================================
     Files          2440     1950      -490     
     Lines        134249   106170    -28079     
     Branches      16179    12970     -3209     
   =============================================
   - Hits          91578    49136    -42442     
   - Misses        35565    51964    +16399     
   + Partials       7106     5070     -2036     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.06% <0.00%> (-12.18%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1587 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147560217

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 45.71%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   45.71%   -22.51%     
   + Complexity    27709    15211    -12498     
   =============================================
     Files          2440     1967      -473     
     Lines        134249   108493    -25756     
     Branches      16179    13468     -2711     
   =============================================
   - Hits          91578    49594    -41984     
   - Misses        35565    53694    +18129     
   + Partials       7106     5205     -1901     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <0.00%> (-12.45%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #18408:
URL: https://github.com/apache/hudi/pull/18408#discussion_r3034372073


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ArchivedTimelineV1.java:
##########
@@ -320,8 +320,10 @@ private InstantsLoader(boolean loadInstantDetails) {
     public void accept(String instantTime, GenericRecord record) {
       Option<HoodieInstant> instant = readCommit(instantTime, record, loadInstantDetails, null);
       if (instant.isPresent()) {
-        instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>())
-            .add(instant.get());
+        List<HoodieInstant> instantsForTime = instantsInRange.computeIfAbsent(instant.get().requestedTime(), s -> new ArrayList<>());
+        if (!instantsForTime.contains(instant.get())) {
+          instantsForTime.add(instant.get());

Review Comment:
   I am using a set for efficient lookups. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185424260

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.53%     
   - Complexity    27709    28049     +340     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92415     +837     
   + Misses        35565    34729     -836     
   - Partials       7106     7281     +175     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <0.00%> (+0.08%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #18408:
URL: https://github.com/apache/hudi/pull/18408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4201316851

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 795be190533a70b9c9354db902730375a1ee79bc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061) 
   * 05f4bc9192dc54b9934318e32f4fe484fb3fe6c8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202592431

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.92%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.92%   -0.29%     
   - Complexity    27709    27764      +55     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    91724     +146     
   - Misses        35565    35871     +306     
   - Partials       7106     7439     +333     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.57%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [246 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202658838

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13056",
       "triggerID" : "4ecd92708329d7a3523d63fdff156c12d25b09f9",
       "triggerType" : "PUSH"
     }, {
       "hash" : "795be190533a70b9c9354db902730375a1ee79bc",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13061",
       "triggerID" : "795be190533a70b9c9354db902730375a1ee79bc",
       "triggerType" : "PUSH"
     }, {
       "hash" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13129",
       "triggerID" : "05f4bc9192dc54b9934318e32f4fe484fb3fe6c8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13136",
       "triggerID" : "a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13136) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185327018

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 45.28%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   45.28%   -22.93%     
   + Complexity    27709    15489    -12220     
   =============================================
     Files          2440     1998      -442     
     Lines        134249   111526    -22723     
     Branches      16179    14118     -2061     
   =============================================
   - Hits          91578    50509    -41069     
   - Misses        35565    55603    +20038     
   + Partials       7106     5414     -1692     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.59%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1569 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185388600

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.74%   +0.52%     
   - Complexity    27709    28048     +339     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   + Hits          91578    92409     +831     
   + Misses        35565    34733     -832     
   - Partials       7106     7283     +177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.69% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <75.00%> (+0.38%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [112 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185223039

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.94%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 26 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   44.94%   -23.27%     
   + Complexity    27709     8476    -19233     
   =============================================
     Files          2440     1195     -1245     
     Lines        134249    61795    -72454     
     Branches      16179     6638     -9541     
   =============================================
   - Hits          91578    27775    -63803     
   + Misses        35565    30991     -4574     
   + Partials       7106     3029     -4077     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `1.37% <0.00%> (-76.40%)` | :arrow_down: |
   
   ... and [2044 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185358057

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.02%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   66.02%   -2.19%     
   + Complexity    27709    26829     -880     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    88755    -2823     
   - Misses        35565    38293    +2728     
   - Partials       7106     7377     +271     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <0.00%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <75.00%> (-0.16%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [427 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147520844

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.97%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   44.97%   -23.24%     
   + Complexity    27709     8454    -19255     
   =============================================
     Files          2440     1194     -1246     
     Lines        134249    61612    -72637     
     Branches      16179     6603     -9576     
   =============================================
   - Hits          91578    27711    -63867     
   + Misses        35565    30881     -4684     
   + Partials       7106     3020     -4086     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `1.37% <0.00%> (-76.40%)` | :arrow_down: |
   
   ... and [2043 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202506015

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.55%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   48.55%   -19.67%     
   + Complexity    27709    16257    -11452     
   =============================================
     Files          2440     1987      -453     
     Lines        134249   109754    -24495     
     Branches      16179    13724     -2455     
   =============================================
   - Hits          91578    53288    -38290     
   - Misses        35565    50940    +15375     
   + Partials       7106     5526     -1580     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <0.00%> (-15.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.82% <0.00%> (-12.42%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1543 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202515029

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.95%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   47.95%   -20.27%     
   + Complexity    27709    16419    -11290     
   =============================================
     Files          2440     2004      -436     
     Lines        134249   112118    -22131     
     Branches      16179    14233     -1946     
   =============================================
   - Hits          91578    53763    -37815     
   - Misses        35565    52691    +17126     
   + Partials       7106     5664     -1442     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <0.00%> (-15.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1529 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202532372

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.27%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   61.27%   -6.94%     
   + Complexity    27709    24987    -2722     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135020     +771     
     Branches      16179    16374     +195     
   ============================================
   - Hits          91578    82735    -8843     
   - Misses        35565    45309    +9744     
   + Partials       7106     6976     -130     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <0.00%> (-15.95%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [603 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202377428

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 44.86%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   44.86%   -23.36%     
   + Complexity    27709     8473    -19236     
   =============================================
     Files          2440     1196     -1244     
     Lines        134249    61894    -72355     
     Branches      16179     6659     -9520     
   =============================================
   - Hits          91578    27767    -63811     
   + Misses        35565    31096     -4469     
   + Partials       7106     3031     -4075     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `1.38% <0.00%> (-76.39%)` | :arrow_down: |
   
   ... and [2047 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202497278

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 46.66%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   46.66%   -21.56%     
   + Complexity    27709    14973    -12736     
   =============================================
     Files          2440     1940      -500     
     Lines        134249   104632    -29617     
     Branches      16179    12606     -3573     
   =============================================
   - Hits          91578    48825    -42753     
   - Misses        35565    50788    +15223     
   + Partials       7106     5019     -2087     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <0.00%> (-12.14%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1630 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147606782

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.22%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18408   +/-   ##
   =========================================
     Coverage     68.21%   68.22%           
   + Complexity    27709    27702    -7     
   =========================================
     Files          2440     2440           
     Lines        134249   134250    +1     
     Branches      16179    16182    +3     
   =========================================
   + Hits          91578    91587    +9     
   + Misses        35565    35559    -6     
   + Partials       7106     7104    -2     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.67% <0.00%> (-0.04%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147625745

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51623cdec56ba782d8aa2904ac753c7922a6a377 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147574600

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 65.73%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   65.73%   -2.49%     
   + Complexity    27709    26647    -1062     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    88247    -3331     
   - Misses        35565    38696    +3131     
   - Partials       7106     7307     +201     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-16.16%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <66.66%> (-0.29%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [372 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147585095

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.36%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.36%   -0.86%     
   + Complexity    27709    27364     -345     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    90436    -1142     
   - Misses        35565    36649    +1084     
   - Partials       7106     7165      +59     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.98% <0.00%> (-3.73%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [158 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147503372

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897",
       "triggerID" : "51623cdec56ba782d8aa2904ac753c7922a6a377",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51623cdec56ba782d8aa2904ac753c7922a6a377 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12897) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147566308

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.66%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (51623cd). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (51623cd) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|3|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   58.66%   -9.55%     
   + Complexity    27709    23858    -3851     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    78764   -12814     
   - Misses        35565    48733   +13168     
   + Partials       7106     6753     -353     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <0.00%> (-15.73%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.59% <0.00%> (-12.65%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [655 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4147590130

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.21%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`51623cd`](https://app.codecov.io/gh/apache/hudi/commit/51623cdec56ba782d8aa2904ac753c7922a6a377?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   68.21%   -0.01%     
   + Complexity    27709    27701       -8     
   ============================================
     Files          2440     2440              
     Lines        134249   134250       +1     
     Branches      16179    16182       +3     
   ============================================
   - Hits          91578    91575       -3     
   - Misses        35565    35568       +3     
   - Partials       7106     7107       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <0.00%> (-0.01%)` | :arrow_down: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (+0.04%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <0.00%> (-0.12%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <66.66%> (+<0.01%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.38% <0.00%> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185343038

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.19%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 17 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   48.19%   -20.02%     
   + Complexity    27709    16432    -11277     
   =============================================
     Files          2440     1998      -442     
     Lines        134249   111526    -22723     
     Branches      16179    14118     -2061     
   =============================================
   - Hits          91578    53755    -37823     
   - Misses        35565    52165    +16600     
   + Partials       7106     5606     -1500     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <0.00%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.59%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185366450

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.17%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   66.17%   -2.05%     
   + Complexity    27709    26896     -813     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    88950    -2628     
   - Misses        35565    38077    +2512     
   - Partials       7106     7398     +292     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.45% <0.00%> (-16.26%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <75.00%> (+0.05%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [409 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185368412

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.77%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.77%   -0.44%     
   + Complexity    27709    27636      -73     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    91113     -465     
   - Misses        35565    35997     +432     
   - Partials       7106     7315     +209     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.96% <0.00%> (-3.75%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <75.00%> (+0.23%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [242 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185371140

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.80%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.80%   -0.42%     
   + Complexity    27709    27643      -66     
   ============================================
     Files          2440     2446       +6     
     Lines        134249   134425     +176     
     Branches      16179    16258      +79     
   ============================================
   - Hits          91578    91146     -432     
   - Misses        35565    35970     +405     
   - Partials       7106     7309     +203     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.52% <0.00%> (+0.20%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <0.00%> (-3.68%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <75.00%> (+0.23%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.35% <0.00%> (-0.02%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.93% <100.00%> (+0.15%)` | :arrow_up: |
   
   ... and [238 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202502490

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 49.11%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|2|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   49.11%   -19.11%     
   + Complexity    27709    16045    -11664     
   =============================================
     Files          2440     1958      -482     
     Lines        134249   107137    -27112     
     Branches      16179    13167     -3012     
   =============================================
   - Hits          91578    52615    -38963     
   - Misses        35565    49161    +13596     
   + Partials       7106     5361     -1745     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <0.00%> (-15.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <0.00%> (-12.29%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1560 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202516026

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.95%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (a2c9ed1). Click for more details.
   > 
   > <details><summary>HEAD has 21 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (a2c9ed1) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|1|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   47.95%   -20.27%     
   + Complexity    27709    16419    -11290     
   =============================================
     Files          2440     2004      -436     
     Lines        134249   112118    -22131     
     Branches      16179    14233     -1946     
   =============================================
   - Hits          91578    53763    -37815     
   - Misses        35565    52691    +17126     
   + Partials       7106     5664     -1442     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.57% <0.00%> (-15.14%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.69%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.41% <100.00%> (-17.37%)` | :arrow_down: |
   
   ... and [1529 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202652628

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.77%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.77%   +0.56%     
   - Complexity    27709    28118     +409     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92875    +1297     
   + Misses        35565    34799     -766     
   - Partials       7106     7360     +254     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.88% <0.00%> (+0.17%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [129 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202595169

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.92%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   - Coverage     68.21%   67.92%   -0.29%     
   - Complexity    27709    27764      +55     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    91727     +149     
   - Misses        35565    35870     +305     
   - Partials       7106     7437     +331     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.56%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [245 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4202627313

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.77%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a2c9ed1`](https://app.codecov.io/gh/apache/hudi/commit/a2c9ed1b23d2b10a78726f9d002fe5a1ed1a32cc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 33 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18408      +/-   ##
   ============================================
   + Coverage     68.21%   68.77%   +0.56%     
   - Complexity    27709    28117     +408     
   ============================================
     Files          2440     2452      +12     
     Lines        134249   135034     +785     
     Branches      16179    16376     +197     
   ============================================
   + Hits          91578    92870    +1292     
   + Misses        35565    34802     -763     
   - Partials       7106     7362     +256     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.43% <0.00%> (+0.11%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.86% <0.00%> (-0.07%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <100.00%> (+0.08%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <0.00%> (+0.10%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <100.00%> (+0.25%)` | :arrow_up: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <0.00%> (-0.16%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `77.77% <100.00%> (ø)` | |
   
   ... and [131 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: avoid duplicate archived timeline instants from leftover merge files [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18408:
URL: https://github.com/apache/hudi/pull/18408#issuecomment-4185307882

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 46.83%. Comparing base ([`1eb97b3`](https://app.codecov.io/gh/apache/hudi/commit/1eb97b31826eabee4fb9c4bf78dc44d2bdb2dad0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`795be19`](https://app.codecov.io/gh/apache/hudi/commit/795be190533a70b9c9354db902730375a1ee79bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 27 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (1eb97b3) and HEAD (795be19). Click for more details.
   > 
   > <details><summary>HEAD has 26 uploads less than BASE</summary>
   >
   >| Flag | BASE (1eb97b3) | HEAD (795be19) |
   >|------|------|------|
   >|spark-scala-tests|10|1|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18408       +/-   ##
   =============================================
   - Coverage     68.21%   46.83%   -21.39%     
   + Complexity    27709    14954    -12755     
   =============================================
     Files          2440     1935      -505     
     Lines        134249   104082    -30167     
     Branches      16179    12503     -3676     
   =============================================
   - Hits          91578    48745    -42833     
   - Misses        35565    50338    +14773     
   + Partials       7106     4999     -2107     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (+0.01%)` | :arrow_up: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <100.00%> (+0.13%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.23% <0.00%> (-12.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ble/timeline/versioning/v1/ArchivedTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18408?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FArchivedTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQXJjaGl2ZWRUaW1lbGluZVYxLmphdmE=) | `60.68% <100.00%> (-17.09%)` | :arrow_down: |
   
   ... and [1623 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org