You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2019/08/24 12:53:00 UTC

[jira] [Commented] (HBASE-20509) Put List in HashSet directly without using addAll function to improve performance

    [ https://issues.apache.org/jira/browse/HBASE-20509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914943#comment-16914943 ] 

Hudson commented on HBASE-20509:
--------------------------------

Results for branch branch-2.1
	[build #1515 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1515/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1515//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1515//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1515//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Put List in HashSet directly without using addAll function to improve performance
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-20509
>                 URL: https://issues.apache.org/jira/browse/HBASE-20509
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: taiyinglee
>            Assignee: taiyinglee
>            Priority: Trivial
>             Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>         Attachments: HBASE-20509.v0.patch
>
>
> [https://docs.oracle.com/javase/7/docs/api/java/util/Collection.html]
> change
> Set<ServerName> serverSet = new HashSet<>();
>  serverSet.addAll(serverList);
> to
> Set<ServerName> serverSet = new HashSet<>(serverList);
> in
> ./hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)