[GitHub] [hadoop] steveloughran commented on a change in pull request #2587: HADOOP-13327 Output Stream Specification.

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #2587:
URL: https://github.com/apache/hadoop/pull/2587#discussion_r571955452



##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
##########
@@ -137,8 +139,13 @@ public void initialize(URI uri, Configuration conf) throws IOException {
             STREAM_READ_SKIP_BYTES)
         .build();
 
+    /** Reference to the bytes read counter for slightly faster counting. */
+    private final AtomicLong bytesRead;
+
     public LocalFSFileInputStream(Path f) throws IOException {
       fis = new FileInputStream(pathToFile(f));
+      bytesRead = ioStatistics.getCounterReference(

Review comment:
       this is a followon to IOStats...it was actually blocked on the buffer between row local fs output and FSDataOutput:
   `org.apache.hadoop.fs.statistics.BufferedIOStatisticsOutputStream` - needed for hsync passthrough to the File output stream. We're now generating IOStats for the local FS too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org