You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/12 14:44:07 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1048: feat(thirdparty): use official rocksdb
acelyc111 opened a new pull request, #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048
https://github.com/apache/incubator-pegasus/issues/1047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1048: feat(thirdparty): use official rocksdb
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048#discussion_r919097840
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -378,9 +378,9 @@ ExternalProject_Add(jemalloc
option(ROCKSDB_PORTABLE "build a portable binary" OFF)
ExternalProject_Add(rocksdb
- URL ${OSS_URL_PREFIX}/pegasus-rocksdb-ef29819c7a1ea9334ae170f506b653757f517a52.zip
- https://github.com/XiaoMi/pegasus-rocksdb/archive/ef29819c7a1ea9334ae170f506b653757f517a52.zip
- URL_MD5 2a6488cd87c37e0c2e42a5ca74bebc87
+ https://github.com/facebook/rocksdb/archive/refs/tags/v6.6.4.tar.gz
Review Comment:
```suggestion
URL https://github.com/facebook/rocksdb/archive/refs/tags/v6.6.4.tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on pull request #1048: feat(thirdparty): use official rocksdb
Posted by GitBox <gi...@apache.org>.
levy5307 commented on PR #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048#issuecomment-1184251565
> hope block merge before release 2.4
Better to convert it to draft :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1048: feat(thirdparty): use official rocksdb
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048#issuecomment-1259743179
> hope block merge before release 2.4
@foreverneverer Since we have created an separete branch v2.4 for releasing 2.4.0, so could we continue this work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1048: feat(thirdparty): use official rocksdb
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org