[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #626: Change the return content in TSQueryDataSet and remove the row record in IoTDBQueryResultSet

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #626: Change the return content in TSQueryDataSet and remove the row record in IoTDBQueryResultSet
URL: https://github.com/apache/incubator-iotdb/pull/626#discussion_r353707537
 
 

 ##########
 File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBQueryResultSet.java
 ##########
 @@ -76,12 +52,13 @@
   private List<String> columnTypeList; // no deduplication
   private Map<String, Integer> columnInfoMap; // used because the server returns deduplicated columns
   private List<String> columnTypeDeduplicatedList; // deduplicated from columnTypeList
-  private RowRecord record;
+  private int rowsIndex = 0;
   private int fetchSize;
   private boolean emptyResultSet = false;
 
   private TSQueryDataSet tsQueryDataSet = null;
-  private ByteBuffer byteBuffer = null;
+  private byte[][] record;
 
 Review comment:
   add some javadoc for this field..
   
   You could separate the time bytes from this record. This record could rename to values

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services