You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qshuai (via GitHub)" <gi...@apache.org> on 2023/02/03 03:37:39 UTC
[GitHub] [rocketmq-client-go] qshuai opened a new pull request, #991: chore: format error log printing
qshuai opened a new pull request, #991:
URL: https://github.com/apache/rocketmq-client-go/pull/991
## What is the purpose of the change
- record error information necessary
- format the key of log entry
- using err instead of err.Error()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #991: chore: format error log printing
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #991:
URL: https://github.com/apache/rocketmq-client-go/pull/991#issuecomment-1414875947
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#991](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1662b6) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/896a8a3453be4bcfcb5bfb5bb9139c4df6d4cdab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (896a8a3) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 23.32% 23.30% -0.02%
==========================================
Files 52 52
Lines 7266 7272 +6
==========================================
Hits 1695 1695
- Misses 5339 5345 +6
Partials 232 232
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/pull\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVsbF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.54% <0.00%> (-0.02%)` | :arrow_down: |
| [internal/model.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvbW9kZWwuZ28=) | `52.97% <0.00%> (-0.29%)` | :arrow_down: |
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `17.31% <0.00%> (-0.09%)` | :arrow_down: |
| [internal/utils/errors.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvZXJyb3JzLmdv) | `0.00% <0.00%> (ø)` | |
| [primitive/nsresolver.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJpbWl0aXZlL25zcmVzb2x2ZXIuZ28=) | `54.20% <0.00%> (ø)` | |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.00% <0.00%> (-0.07%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org